Conversation
Replace java.net.URI with java.net.URL throughout HtmlTransformer to simplify URL resolution logic. Remove deprecated URI-based overloads and eliminate the complex fallback path that manually reconstructed absolute URLs when URISyntaxException was thrown. The URL class handles relative URL resolution natively, making the code cleaner and more straightforward. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
java.net.URIwithjava.net.URLthroughoutHtmlTransformerto simplify URL resolution logic and remove now-redundant code.Changes Made
URI-based URL resolution withURL-based resolution instoreData()getUrlFromTagAttribute(URL, ...)andaddChildUrlFromTagAttribute(URL, ...)overloads that delegated to theirURIcounterpartsaddChildUrlFromTagAttributethat manually reconstructed absolute URLs whenURISyntaxExceptionwas thrown/../-prefixed paths directly afterURLresolution, which is the only edge caseURLdoesn't normalize automaticallyURISyntaxExceptioncatch forMalformedURLException— cleaner and more preciseTesting
URL.resolve()now handles nativelyBreaking Changes
getUrlFromTagAttribute(URI, ...)andaddChildUrlFromTagAttribute(URI, ...)methods are removed. Any subclasses overriding those methods will need to migrate to theURL-based signatures.Additional Notes
The previous implementation used
URIas the primary type but keptURLwrappers marked@Deprecated, then added a large manual fallback whenURISyntaxExceptionwas thrown. Sincejava.net.URLresolves relative references natively and the only gap (/../normalization) is a small explicit check, the URI path is no longer needed.