Conversation
…rove DocBoostMatcher error handling GroovyEngine now caches compiled Groovy Script classes in an LRU map (max 100 entries), avoiding repeated compilation of the same script text. Each evaluation still creates a fresh Script instance for thread-safe binding isolation. GroovyClassLoaders are properly closed on eviction and via @PreDestroy. DocBoostMatcher now catches NumberFormatException when parsing boost values, logging a warning and returning 0.0f instead of propagating the exception. Includes comprehensive tests for cache behavior, binding isolation, eviction, concurrent evaluation, close lifecycle, and new DocBoostMatcher edge cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… in GroovyEngine Replace the manual synchronized LinkedHashMap-based LRU cache with Guava Cache for compiled Groovy scripts. This provides segment-based locking for lock-free concurrent reads and automatic eviction via RemovalListener. Also makes scriptCacheSize and maxScriptLogLength configurable via DI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@PreDestroy.NumberFormatExceptionwhen parsing boost values, log a warning and return0.0finstead of propagating the exception.Test plan
mvn test)🤖 Generated with Claude Code