Skip to content

fix(upload): update commons-fileupload API and add IOException handling #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marevol merged 1 commit into from
Mar 15, 2026
Merged

fix(upload): update commons-fileupload API and add IOException handling #3079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/main/java/org/codelibs/fess/mylasta/direction/sponsor/FessMultipartRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ protected void throwTooLongBoundarySizeException(final String contentType, final

protected void setupServletFileUpload(final JakartaServletDiskFileUpload upload, final HttpServletRequest request) {
upload.setHeaderCharset(Charset.forName(request.getCharacterEncoding()));
upload.setSizeMax(getSizeMax());
upload.setFileCountMax(getFileCountMax()); // since commons-fileupload-1.5
upload.setMaxSize(getSizeMax());
upload.setMaxFileCount(getFileCountMax()); // since commons-fileupload-1.5
}

protected long getSizeMax() {
Expand Down Expand Up @@ -235,7 +235,11 @@ protected void showFieldLoggingTitle() {

protected void showFormFieldParameter(final DiskFileItem item) {
if (logger.isDebugEnabled()) {
logger.debug("[param] {}={}", item.getFieldName(), item.getString());
try {
logger.debug("[param] {}={}", item.getFieldName(), item.getString());
} catch (final IOException e) {
logger.debug("[param] {}=(failed to read)", item.getFieldName());
}
}
}

Expand Down Expand Up @@ -263,7 +267,11 @@ protected void addTextParameter(final HttpServletRequest request, final DiskFile
try {
value = item.getString(Charset.forName("ISO-8859-1"));
} catch (final java.io.UnsupportedEncodingException uee) {
value = item.getString();
try {
value = item.getString();
} catch (final IOException e) {
throw new IllegalStateException("Failed to get string from the item: " + item, e);
}
} catch (final IOException e) {
throw new IllegalStateException("Failed to get string from the item: " + item, e);
}
Expand Down
Loading