fix(security): prevent path traversal and symlink attacks in IndexExportJob#3080
Merged
fix(security): prevent path traversal and symlink attacks in IndexExportJob#3080
Conversation
…ortJob Add path traversal prevention by stripping `.` and `..` components, normalizing resolved paths, and validating they stay within the export base directory. Add symlink traversal prevention by resolving real paths and using NOFOLLOW_LINKS when writing files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9c82773 to
eb124d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.and..path components and normalize resolved paths inbuildFilePath()to prevent directory traversal attacks_invalid/directory for malicious URLsexportDocument()by resolving real paths and usingNOFOLLOW_LINKSwhen writing filesTest plan
IndexExportJobTesttests pass🤖 Generated with Claude Code