Skip to content

Use HTTP PUT for START/STOP actions in Fess versions above 14#18

Merged
marevol merged 1 commit intomainfrom
fix/start-stop-method-compat
Aug 14, 2025
Merged

Use HTTP PUT for START/STOP actions in Fess versions above 14#18
marevol merged 1 commit intomainfrom
fix/start-stop-method-compat

Conversation

@marevol
Copy link
Contributor

@marevol marevol commented Aug 14, 2025

This update modifies the request method for Action.START and Action.STOP in FessAPIClient.

  • For Fess versions 14 or below, the client continues using httpx.post.
  • For versions above 14, the client now uses httpx.put to align with API changes.

This change ensures compatibility with newer Fess API specifications while maintaining backward compatibility for older versions.

@marevol marevol requested a review from Copilot August 14, 2025 01:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the FessAPIClient to support Fess version compatibility by using different HTTP methods for START/STOP actions based on the Fess version.

  • Changes HTTP method from POST to PUT for START/STOP actions when Fess version is above 14
  • Maintains backward compatibility by continuing to use POST for Fess versions 14 and below
  • Adds version-specific logic to handle API specification changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@marevol marevol merged commit 5443094 into main Aug 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants