Conversation
…Docker Compose selection
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the testing infrastructure to support multiple Fess and OpenSearch version combinations by implementing a matrix strategy in GitHub Actions and dynamic Docker Compose file selection. The change enables testing against both legacy (14.19.2/2.19.1) and current (15.1.0/3.1.0) versions to ensure broader compatibility.
- Renamed GitHub Actions job from "build" to "test" and added matrix strategy for two version combinations
- Implemented dynamic Docker Compose file selection based on FESS_VERSION environment variable
- Created separate compose files for Fess 14.x and 15.x with appropriate version defaults
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/run-tests.yml | Added matrix strategy for testing multiple Fess/OpenSearch version combinations |
| tests/conftest.py | Implemented dynamic compose file selection logic based on FESS_VERSION |
| tests/compose-fess15.yaml | Updated existing compose file to use environment variables for Fess 15.x |
| tests/compose-fess14.yaml | New compose file created for Fess 14.x compatibility testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for testing against multiple versions of Fess and OpenSearch by:
This ensures broader compatibility testing and aligns test infrastructure with multiple Fess versions.