Monster spawners based on warnings (issue #110)#111
Open
Hanziness wants to merge 19 commits intocodemetropolis:masterfrom
Open
Monster spawners based on warnings (issue #110)#111Hanziness wants to merge 19 commits intocodemetropolis:masterfrom
Hanziness wants to merge 19 commits intocodemetropolis:masterfrom
Conversation
4 spawners added to every building
…n ConverterExecutorArgs and MappingExecutorArgs tests
… toolchain element
… for ConversionTest class in the mapping toolchain element
…nd for ProgressEventTest and CharacterTest classes in the rendering toolchain element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have added the ability to create monster spawners in the generated worlds' gardens. These spawners are created based on an attribute named
monster-count(acceptable integer values range from 0 to 4). The attribute can be added by the mapping tool. We also place signposts near the created spawners. The label of the signposts is determined by themonster-labelattribute. An example mapping XML file (which is a modified version ofsourcemeter_mapping_example_2_0.xml) that demonstrates this functionality is also included within our modifications.We have also implemented unit tests for 30 methods. The GitHub Pages documentation was also updated to reflect the proposed changes - this will be submitted in a separate pull request.
This pull request is submitted as a solution to issue #110.