Removed unused common.h and corrected print statement#189
Merged
sai-kaushik-s merged 1 commit intoMay 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused 02/concurrency/common.h header and updates the small concurrency examples/build rules accordingly, including correcting the usage string in threads-notv.c.
Changes:
- Removed
#include "common.h"fromthreads.candthreads-notv.c. - Deleted
02/concurrency/common.hand updated02/concurrency/Makefiletarget dependencies to no longer reference it. - Corrected the
threads-notvusage message to match the binary name.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| 02/concurrency/threads.c | Drops unused common.h include. |
| 02/concurrency/threads-notv.c | Drops unused common.h include; fixes usage string. |
| 02/concurrency/common.h | Deletes unused local timing/spin header. |
| 02/concurrency/Makefile | Removes common.h from target prerequisites. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Vinuthna-G-1091
changed the title
namanlp
force-pushed
the
main
branch
4 times, most recently
from
7ed076d to
443bf42
Compare
sai-kaushik-s
approved these changes
May 9, 2026
sai-kaushik-s
pushed a commit
that referenced
this pull request
May 9, 2026
sai-kaushik-s
added
Spring2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed an unused header file common.h and cleaned up all references to it in the source files.
Updated the Makefile to remove dependencies on the deleted header.
Corrected a print statement in threads-notv.c file from threads to threads-notv
No functional changes; build verified successfully.