Skip to content

Fix incomplete clean target in 02/Makefile#58

Closed
legends1307 wants to merge 1 commit into
codenet:mainfrom
legends1307:fix-makefile-clean-target-02
Closed

Fix incomplete clean target in 02/Makefile#58
legends1307 wants to merge 1 commit into
codenet:mainfrom
legends1307:fix-makefile-clean-target-02

Conversation

@legends1307

Copy link
Copy Markdown

Problem

The clean target in 02/Makefile is incomplete and has two issues:

  1. Missing executable removal: The target removes intermediate files (*. o, *.s, *. dump) but doesn't remove the final executable 02.main that is built by the all target
  2. No error handling: Uses rm without the -f flag, which will cause errors if files don't exist

Solution

This PR fixes both issues:

  • Adds 02.main to the list of files to be removed
  • Adds the -f flag to rm to prevent errors when files are missing

@namanlp namanlp added Spring2026 PR made be Spring 2026 students, possibly for errata participation. Blocked Can't be merged, requires student to provide more context/fix PR. labels Mar 11, 2026
@namanlp namanlp force-pushed the main branch 4 times, most recently from 7ed076d to 443bf42 Compare March 18, 2026 11:45
@namanlp

namanlp commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

I am closing this since it is stale

@namanlp namanlp closed this Apr 29, 2026
@sai-kaushik-s sai-kaushik-s added the Remove Dead Code Removes some dead code from code base label May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked Can't be merged, requires student to provide more context/fix PR. Remove Dead Code Removes some dead code from code base Spring2026 PR made be Spring 2026 students, possibly for errata participation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants