Skip to content

Description of MSRs module#12

Open
Krishnanshu1907 wants to merge 1 commit into
codenet:mainfrom
Krishnanshu1907:main
Open

Description of MSRs module#12
Krishnanshu1907 wants to merge 1 commit into
codenet:mainfrom
Krishnanshu1907:main

Conversation

@Krishnanshu1907

Copy link
Copy Markdown

No description provided.

Comment thread Vmm-reference-MSRs.md
Comment thread Vmm-reference-MSRs.md
Comment thread Vmm-reference-MSRs.md
Comment thread Vmm-reference-MSRs.md
Comment thread Vmm-reference-MSRs.md

@codenet codenet left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits. Good PR.

Comment thread Vmm-reference-MSRs.md
const MSR_IA32_SPEC_CTRL: u32 = 0x0000_0048;
const MSR_IA32_PRED_CMD: u32 = 0x0000_0049;
```
The above piece of code defines some constant used in the the below. Here we have only defined list of the index of the custom msrs.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the the -> the code?

Comment thread Vmm-reference-MSRs.md
```rs
pub fn create_boot_msr_entries() -> Result<Msrs>
```
This fucntion returs list of Msrs, let's try to understand that. The kvm holds the all the msrs using following structs defined in `[binding.rs](kvm-bindings-0.5.0/src/x86/bindings.rs)`

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fucntion -> function
returs -> returns
holds the -> holds

Comment thread Vmm-reference-MSRs.md
}
```
The struct `kvm_msr_entry` holds single register with member `index`,`reserved` and `data`.
The struct `kvm_msrs` holds all the msrs using an flexible array.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an -> a

Comment thread Vmm-reference-MSRs.md
Comment on lines +187 to +197











Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm empty lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants