Description of vmm/src/lib.rs (VMM Struct and Implementation)#24
Open
ramrap wants to merge 2 commits into
Open
Description of vmm/src/lib.rs (VMM Struct and Implementation)#24ramrap wants to merge 2 commits into
ramrap wants to merge 2 commits into
Conversation
ramrap
changed the title
hghai14
reviewed
Sep 12, 2022
its-sachin
reviewed
Sep 12, 2022
decoder3
reviewed
Sep 12, 2022
ap143
reviewed
Sep 13, 2022
ap143
reviewed
Sep 17, 2022
| @@ -0,0 +1,107 @@ | |||
| # [VMM Impl](../src/vmm/src/lib.rs) | |||
|
|
|||
Comment on lines
+41
to
+42
| let kernel_load_addr = self.compute_kernel_load_addr(&load_result)?; | ||
| let kernel_load_addr = self.compute_kernel_load_addr(&load_result)?; |
codenet
approved these changes
Sep 20, 2022
Comment on lines
+20
to
+23
| - `guest_memory` - The guest memory object. It is created when the VMM starts. It is wrapped in a `GuestMemoryMmap` object that provides a safe interface to the guest memory. | ||
| - `device_mgr` - The device manager object. It is created when the VMM starts. It is responsible for managing the devices attached to the VMM. | ||
| - `event_mgr` - The event manager object. It is created when the VMM starts. It is responsible for managing the events that are generated by the devices attached to the VMM. | ||
| - `exit_handler` - The exit handler object. It is created when the VMM starts. It is responsible for handling the VM exits. |
Owner
There was a problem hiding this comment.
lot of redundancy in these statements. You can just say
exit_handler: responsible for handling VM exits.
Minor Errors Fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.