Merged
Conversation
Collaborator
Author
|
cc: @matifali @hugodutka |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the message formatting support for the Codex agent type by introducing a specialized formatter that handles Codex-specific message box patterns. The changes enable proper parsing and extraction of relevant content from Codex agent responses.
- Adds a new
formatCodexMessagefunction to handle Codex-specific message formatting - Implements
removeCodexMessageBoxfunction to parse Codex's unique message box patterns - Updates the agent message formatter to use the new Codex-specific logic
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/msgfmt/msgfmt.go | Adds formatCodexMessage function and updates FormatAgentMessage to use Codex-specific formatting |
| lib/msgfmt/message_box.go | Implements removeCodexMessageBox function to handle Codex message box parsing |
| lib/msgfmt/testdata/format/codex/* | Updates test data files to reflect new Codex message formatting behavior |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hugodutka
requested changes
Jul 31, 2025
Collaborator
hugodutka
left a comment
hugodutka
left a comment
There was a problem hiding this comment.
Thank you for contributing. The PR largely look good. I have 2 asks:
- Could you add some tests for multi-line user input?
- Could you note in the README that if you're using Codex you should make sure to specify agent type when starting
agentapi server? Since we used the same logic for every agent before it didn't matter, but now it does.
Collaborator
Author
|
@hugodutka made the required changes. |
johnstcn
reviewed
Jul 31, 2025
Collaborator
Author
hugodutka
approved these changes
Aug 4, 2025
Collaborator
hugodutka
left a comment
hugodutka
left a comment
There was a problem hiding this comment.
Looks great. Two minor nits and we can merge it.
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/af76ebf12da14b83b84f53298d947343?sid=ff871cfa-4cd7-4fe7-a576-f0b92e65ad95