feat: add HTTP request/response body logging with RequestLogger trait#49
Closed
feat: add HTTP request/response body logging with RequestLogger trait#49
Conversation
Implement comprehensive body logging functionality that logs HTTP request and response bodies when HTTPJAIL_REQUEST_LOG_BODY environment variable is set. Changes: - Add RequestLogger trait with FileRequestLogger and NoopLogger implementations - Move request logging logic from rules.rs to new request_log.rs module - Create body_logger.rs module with streaming body wrappers - Update RuleEngine to accept RequestLogger trait instead of Option<File> - Add request ID generation and correlation for request/response pairs - Support both text and binary body logging (with base64 encoding) - Zero performance impact when body logging is disabled The new architecture provides cleaner separation of concerns and makes the API more extensible for future logging backends. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
New Architecture
Body Logging Features
Log Format
Test Plan
🤖 Generated with Claude Code