feat: goose: add support for subdomain=false

[johnstcn]

Updates coder/coder#18779
Builds on #297

Description

Adds support for specifying subdomain = false in the agentapi module.
Change added in #297
NOTE: AGENTAPI_CHAT_BASE_PATH is exported before running main.sh in agentapi, so this environment variable is available to calling modules if var.subdomain = false.

Type of Change

• New module
• Bug fix
• Feature/enhancement
• Documentation
• Other

Testing & Validation

• Tests pass (bun test)
• Code formatted (bun run fmt)
• Changes tested locally

Related Issues

coder/coder#18779

[Copilot]

Pull Request Overview

This PR adds support for specifying subdomain = false in the goose module to allow AgentAPI to be accessed without using a subdomain. This builds on changes in the coder/registry repository and addresses issue #18779.

• Added a new subdomain variable to control whether AgentAPI uses a subdomain
• Updated the start script to conditionally include the --chat-base-path parameter when subdomain is disabled
• Added test coverage for the new subdomain=false functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
registry/coder/modules/goose/main.tf	Added subdomain variable and updated agentapi module version with subdomain parameter
registry/coder/modules/goose/scripts/start.sh	Modified script to conditionally add chat-base-path argument based on environment variable
registry/coder/modules/goose/main.test.ts	Added test case to verify subdomain=false functionality works correctly

[hugodutka]

Hmm, instead of passing the base path as a command line argument, why don't we update AgentAPI to support configuration via environment variables? Then you'd only need to specify the chat base path before running main.sh in main.tf, and all dependent modules would pick it up automatically. What do you think @johnstcn? I was planning to add that feature anyway.

[DevelopmentCats]

LGTM since we have addressed the above comments.
Outside of waiting for #297 to be approved, Can you bump the module version for goose with a patch bump as well?

[johnstcn]

Hmm, instead of passing the base path as a command line argument, why don't we update AgentAPI to support configuration via environment variables? Then you'd only need to specify the chat base path before running main.sh in main.tf, and all dependent modules would pick it up automatically. What do you think @johnstcn? I was planning to add that feature anyway.

Done

[johnstcn]

LGTM since we have addressed the above comments. Outside of waiting for #297 to be approved, Can you bump the module version for goose with a patch bump as well?

Done!