Conversation
- Also adds it to the coderd_organization data source - Also adds an option to the test harness to test against features gated by experiments (enabled via the CODER_EXPERIMENTS env var) Related to: coder/internal#1245
aslilac
approved these changes
Jan 22, 2026
Member
aslilac
left a comment
aslilac
left a comment
There was a problem hiding this comment.
one small thing but otherwise looks great!
Gracefully handle older coderd versions or disabled workspace-sharing experiment, and bump coder dependency to the new official mainline version (v2.30.0).
…-workspace-sharing-attr
geokat
force-pushed
the
geokat/internal-1245-add-coderd-organization-workspace-sharing-attr
branch
2 times, most recently
from
354f4ac to
11f12ab
Compare
go v1.25 is now required by the dependencies we pull in (coder/v2). - pin golangci-lint to v2.4.0 in CI - update .golangci.yml to v2 schema (default none, formatter config, settings move) - bump golangci-lint-action to v8 so v2.x installs correctly
geokat
force-pushed
the
geokat/internal-1245-add-coderd-organization-workspace-sharing-attr
branch
from
11f12ab to
77774a6
Compare
- check error return values - return error as last value (ST1008)
Allow integration tests to provide Coder image/version/experiments while deferring to environment overrides.
Add no-experiment and backward-compat paths for resource/data source tests, using shared helpers to avoid duplication.
geokat
deleted the
geokat/internal-1245-add-coderd-organization-workspace-sharing-attr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace_sharingto thecoderd_organizationresource and data sourceTesting
Other changes
Related to: coder/internal#1245