Skip to content

SANDBOX-1769 | feature: "disabled integrations" builder for the tests#524

Merged
MikelAlejoBR merged 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enabled-integrations-tc
Apr 16, 2026
Merged

SANDBOX-1769 | feature: "disabled integrations" builder for the tests#524
MikelAlejoBR merged 1 commit intocodeready-toolchain:masterfrom
MikelAlejoBR:SANDBOX-1769-feature-enabled-integrations-tc

Conversation

@MikelAlejoBR
Copy link
Copy Markdown
Contributor

@MikelAlejoBR MikelAlejoBR commented Apr 10, 2026

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3726f2bd-452d-4b33-98d5-77f2d55d68c6

📥 Commits

Reviewing files that changed from the base of the PR and between d25d828 and 59531dd.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod
  • pkg/test/config/toolchainconfig.go

Walkthrough

Updated a Go module dependency version for github.com/codeready-toolchain/api and added a new configuration option method DisabledIntegrations() to manage disabled integrations in the registration service test configuration.

Changes

Cohort / File(s) Summary
Dependency Update
go.mod
Updated github.com/codeready-toolchain/api dependency from v0.0.0-20260305144020-4ff0e6b6e174 to v0.0.0-20260415142422-12ff40f3bdb6.
Configuration Option
pkg/test/config/toolchainconfig.go
Added new DisabledIntegrations(values []string) method to RegistrationServiceOption that sets the corresponding config field with a cloned slice; included slices import.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding a 'disabled integrations' builder for tests, which is directly reflected in the added DisabledIntegrations() method.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update dependency to API in go.mod

@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-tc branch from 5e11952 to 6c26371 Compare April 14, 2026 19:58
@MikelAlejoBR MikelAlejoBR changed the title SANDBOX-1769 | feature: "enabled integrations" builder for the tests SANDBOX-1769 | feature: "disabled integrations" builder for the tests Apr 14, 2026
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-tc branch from 6c26371 to 095322e Compare April 15, 2026 16:28
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-tc branch 6 times, most recently from 54b4567 to 820149d Compare April 16, 2026 14:02
Adds the required test builder for the "disabled integrations" feature,
to make testing easier.

SANDBOX-1769
@MikelAlejoBR MikelAlejoBR force-pushed the SANDBOX-1769-feature-enabled-integrations-tc branch from 820149d to 59531dd Compare April 16, 2026 20:19
@sonarqubecloud
Copy link
Copy Markdown

@MikelAlejoBR MikelAlejoBR merged commit 1fd670b into codeready-toolchain:master Apr 16, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants