-
Notifications
You must be signed in to change notification settings - Fork 3
Issue 8 individual art pages #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…/game-dev into issue-8/art-page
…flict Issue 8 resolve merge conflict
laurenpudz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello!! could you please resolve the conflicts between this branch and the main branch, thanks!
|
Hey! Seems like some conflicts have cropped up since the new events page was merged into main. Please could you resolve these too! |
| fontFamily: { | ||
| sans: ["var(--font-sans)", ...fontFamily.sans], | ||
| jersey10: ["var(--font-jersey10)", ...fontFamily.sans], | ||
| jersey10: ["Jersey 10", ...fontFamily.sans], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this font's definition changed?
Change Summary
Improved responsive design and refactored artwork pages to follow Next.js best practices. Centralized mock data generation into a reusable hook and added proper error handling for empty database states.
Changes Made
ButtonGallerycomponent to use Next.jsLinkcomponent properlyuseArtworkData.tshookgetServerSidePropsto return mock data when API fails or DB is emptyChange Form
Other Information
Testing Notes:
Related issue