Conversation
boscard
left a comment
There was a problem hiding this comment.
Can you move all yml file to different directory, for example subdirectory templates ?
.cilibs/compile_code.sh
Outdated
| done | ||
|
|
||
| echo "Compile code" | ||
| if [ -z "$TRAVIS_BRANCH" ] |
There was a problem hiding this comment.
And what about "$CIRCLECI_BRANCH" part ?
There was a problem hiding this comment.
Yeah, it was messed up, should work now.
| FLOODGATE_EXTRA_PARAMS=$1 | ||
|
|
||
| echo Test Floodgate against running Spinnaker instance | ||
| /floodgate/bin/floodgate --version |
There was a problem hiding this comment.
Maybe you can add some info about what is happening before executing this commands?
There was a problem hiding this comment.
Added printing as was in .circleci/config.yml
.travis.yml
Outdated
| go: | ||
| - 1.14.1 | ||
| env: | ||
| - REALESE_BRANCHES="release-v[0-9]+\.[0-9]+\.x" RELEASE_TAGS="v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?" BUILD_OS="$([ $TRAVIS_EVENT_TYPE == cron ] || [[ $TRAVIS_BRANCH =~ $RELEASE_BRANCHES ]] || [[ $TRAVIS_TAG =~ $RELEASE_TAGS ]] && echo darwin) linux" BUILD_ARCH=amd64 GATE_API_BRANCH=release-1.20.x SEND_COVERITY=send |
There was a problem hiding this comment.
Can you use here multiline syntax for example with | ?
There was a problem hiding this comment.
Improved readability but I don't see how I could make declaration of BUILD_ARCH more clear.
| @@ -0,0 +1,19 @@ | |||
| dist: xenial | |||
There was a problem hiding this comment.
What about kind of periodic workflow?
4e1a2e2 to
35cbdd5
Compare
PR includes configuration and scripts needed to use travis as CI. All code is moved to bash scripts that are used by both CircleCI and Travis.
What is missing in comparison with CircleCI: