ci(lint): expand scripts and config lint coverage #115
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -121,8 +121,7 @@ function readWorkflowFiles(workflowDirectory) { | |
| const entries = fs | ||
| .readdirSync(directoryPath, { withFileTypes: true }) | ||
| .filter( | ||
| (entry) => entry.isFile() && (entry.name.endsWith('.yml') || entry.name.endsWith('.yaml')) | ||
| ) | ||
| .map((entry) => entry.name) | ||
| .sort((left, right) => left.localeCompare(right)); | ||
|
|
@@ -203,7 +202,9 @@ async function githubRequest({ endpoint, token, method = 'GET', body = null }) { | |
|
|
||
| if (!response.ok) { | ||
| const detail = data && typeof data === 'object' && data.message ? data.message : responseText; | ||
| const error = new Error( | ||
| `GitHub API ${method} ${endpoint} failed (${response.status}): ${detail}` | ||
| ); | ||
| error.status = response.status; | ||
| throw error; | ||
| } | ||
|
|
@@ -406,7 +407,8 @@ async function ensureTrackingPullRequestBranch({ | |
| endpoint: `/repos/${encodeURIComponent(owner)}/${encodeURIComponent(repository)}/git/ref/heads/${toGitHubRefPath(defaultBranch)}`, | ||
| token, | ||
| }); | ||
| const defaultBranchSha = | ||
| defaultBranchRef && defaultBranchRef.object ? defaultBranchRef.object.sha : ''; | ||
| if (!defaultBranchSha) { | ||
| throw new Error(`Could not resolve latest commit on ${defaultBranch}.`); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,13 @@ const DEFAULT_SCREENSHOT_NAME = `ui-${process.platform}-${process.arch}.png`; | |
| const FIXED_MTIME = 1700000000000; | ||
|
|
||
| function loadSecretScannerHelpers() { | ||
| const compiledSecretScannerPath = path.join( | ||
| ROOT_DIR, | ||
| 'build', | ||
| 'ts', | ||
| 'utils', | ||
| 'secret-scanner.js' | ||
| ); | ||
|
|
||
| try { | ||
| return require(compiledSecretScannerPath); | ||
|
|
@@ -49,7 +55,10 @@ function sanitizeScreenshotName(nameCandidate) { | |
| typeof nameCandidate === 'string' && nameCandidate.trim() | ||
| ? nameCandidate.trim() | ||
| : DEFAULT_SCREENSHOT_NAME; | ||
| const baseName = path | ||
| .basename(rawName) | ||
| .replace(/[^a-zA-Z0-9._-]/g, '-') | ||
| .replace(/^\.+/, ''); | ||
| const withExtension = baseName.toLowerCase().endsWith('.png') ? baseName : `${baseName}.png`; | ||
|
|
||
| if (!withExtension || withExtension === '.png') { | ||
|
|
@@ -361,7 +370,8 @@ async function setupMockElectronApi(page) { | |
| localStorage.setItem('configContent', mockConfig); | ||
|
|
||
| const cloneTree = (treeItems) => JSON.parse(JSON.stringify(treeItems)); | ||
| const delay = (durationMs) => | ||
| new Promise((resolve) => window.setTimeout(resolve, durationMs)); | ||
|
|
||
| window.electronAPI = { | ||
| getDefaultConfig: async () => mockConfig, | ||
|
|
@@ -371,14 +381,19 @@ async function setupMockElectronApi(page) { | |
| typeof configContent === 'string' && configContent.trim() | ||
| ? configContent | ||
| : localStorage.getItem('configContent') || ''; | ||
| const configLines = activeConfig | ||
| .split('\n') | ||
| .map((line) => line.trim().toLowerCase().replaceAll(' ', '').replaceAll('\t', '')); | ||
| const hasSecretScanningDisabled = configLines.includes('enable_secret_scanning:false'); | ||
| const hasSuspiciousFilesDisabled = configLines.includes('exclude_suspicious_files:false'); | ||
| const excludeSensitiveFiles = !hasSecretScanningDisabled && !hasSuspiciousFilesDisabled; | ||
| const tree = excludeSensitiveFiles ? mockFilteredDirectoryTree : mockDirectoryTree; | ||
| return cloneTree(tree); | ||
| }, | ||
| analyzeRepository: async (options = {}) => { | ||
| const selectedFilePaths = Array.isArray(options?.selectedFiles) | ||
| ? options.selectedFiles | ||
| : []; | ||
| const filesInfo = selectedFilePaths.map((filePath, index) => { | ||
| const normalizedPath = String(filePath); | ||
| const relativePath = normalizedPath.startsWith(`${mockRootPath}/`) | ||
|
|
@@ -402,7 +417,9 @@ async function setupMockElectronApi(page) { | |
| const filesInfo = inputFilesInfo.map((file, index) => ({ | ||
| path: String(file?.path || `src/file-${index + 1}.ts`), | ||
| tokens: | ||
| Number.isFinite(file?.tokens) && Number(file.tokens) > 0 | ||
| ? Number(file.tokens) | ||
| : 120 * (index + 1), | ||
| isBinary: false, | ||
| })); | ||
| const totalTokens = filesInfo.reduce((sum, file) => sum + file.tokens, 0); | ||
|
|
@@ -422,7 +439,8 @@ async function setupMockElectronApi(page) { | |
| '# Repository Analysis', | ||
| '', | ||
| ...filesInfo.map( | ||
| (file) => | ||
| `## ${file.path}\n\n\`\`\`ts\n// Preview for ${file.path}\n\`\`\`\nTokens: ${file.tokens}\n` | ||
| ), | ||
| '--END--', | ||
| ].join('\n'); | ||
|
|
@@ -516,7 +534,10 @@ async function captureAppStateScreenshots(page) { | |
| }); | ||
|
|
||
| await runStep('Verify secret files are hidden by default', async () => { | ||
| await page.waitForFunction( | ||
| (selector) => !document.querySelector(selector), | ||
| UI_SELECTORS.secretFileEntry | ||
| ); | ||
| }); | ||
|
|
||
| await runStep('Capture source tab screenshot', async () => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,12 +31,9 @@ function extractUsesValue(line) { | |
| return ''; | ||
| } | ||
|
|
||
| const withoutPrefix = normalized.slice(USES_LINE_PATTERN.length).trimStart(); | ||
| const commentStart = withoutPrefix.search(/\s#/); | ||
| const rawValue = commentStart >= 0 ? withoutPrefix.slice(0, commentStart) : withoutPrefix; | ||
|
|
||
| return normalizeReferenceValue(rawValue.trim()); | ||
| } | ||
|
|
@@ -131,10 +128,7 @@ function escapeMarkdownTableCell(value) { | |
| return ''; | ||
| } | ||
|
|
||
| return String(value).replace(/\\/g, '\\\\').replace(/\r?\n/g, '<br>').replace(/\|/g, '\\|'); | ||
| } | ||
|
|
||
| function buildMarkdownReport(report) { | ||
|
|
@@ -202,7 +196,9 @@ function buildMarkdownReport(report) { | |
| } | ||
|
|
||
| if (report.staleCount === 0 && report.resolutionErrors.length === 0) { | ||
| lines.push( | ||
| 'All pinned GitHub Actions references are current against latest upstream releases.' | ||
| ); | ||
| lines.push(''); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,7 +99,9 @@ function resolveCommand(command, localCandidates = []) { | |
| } | ||
|
|
||
| for (const candidate of localCandidates) { | ||
| const absolutePath = path.isAbsolute(candidate) | ||
| ? candidate | ||
| : path.join(utils.ROOT_DIR, candidate); | ||
| if (fs.existsSync(absolutePath)) { | ||
| return absolutePath; | ||
| } | ||
|
|
@@ -285,7 +287,9 @@ function resolveTokenFromFile() { | |
| return ''; | ||
| } | ||
|
|
||
| const tokenFilePath = path.isAbsolute(tokenFile) | ||
| ? tokenFile | ||
| : path.join(utils.ROOT_DIR, tokenFile); | ||
| if (!fs.existsSync(tokenFilePath)) { | ||
| return ''; | ||
| } | ||
|
|
@@ -508,7 +512,8 @@ async function runMendScan() { | |
| assertAllowedExecutable(mendPath); | ||
|
|
||
| const pkg = readPackageMetadata(); | ||
| const project = | ||
| process.env.MEND_PROJECT || process.env.BINARY_NAME || pkg.name || 'ai-code-fusion'; | ||
| const version = process.env.MEND_PROJECT_VERSION || process.env.VERSION || pkg.version || '0.0.0'; | ||
| const commandName = process.platform === 'win32' ? 'mend-scan.exe' : 'mend-scan'; | ||
| const args = ['scan', '--project', project, '--version', version]; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -230,7 +230,9 @@ function printHelp() { | |
| console.log(' prometheus:verify - Verify pushed stress metrics in Prometheus'); | ||
| console.log(' perf-test - Run stress tests, push metrics, and verify Prometheus'); | ||
| console.log(' lint - Run linter'); | ||
| console.log( | ||
| ' lint:md - Validate markdown links, image paths, and no decorative icons' | ||
| ); | ||
| console.log(' format - Format code'); | ||
| console.log(' validate - Run all code quality checks'); | ||
| console.log(' qa - Run lint + tests + security checks'); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,7 +62,11 @@ function normalizeTarget(rawTarget) { | |
| function resolveTargetPath(markdownFilePath, target) { | ||
| const [pathWithoutAnchor] = target.split('#'); | ||
|
|
||
| if ( | ||
| !pathWithoutAnchor || | ||
| isExternalTarget(pathWithoutAnchor) || | ||
| pathWithoutAnchor.startsWith('#') | ||
| ) { | ||
| return null; | ||
| } | ||
|
|
||
|
|
@@ -131,7 +135,11 @@ function lintMarkdownFile(markdownFilePath) { | |
| const rawTargets = extractTargetsFromLine(line); | ||
| for (const rawTarget of rawTargets) { | ||
| const normalizedTarget = normalizeTarget(rawTarget); | ||
| if ( | ||
| !normalizedTarget || | ||
| isExternalTarget(normalizedTarget) || | ||
| normalizedTarget.startsWith('#') | ||
| ) { | ||
| continue; | ||
| } | ||
|
|
||
|
|
@@ -177,12 +185,16 @@ function run() { | |
| const relativeFilePath = path.relative(ROOT_DIR, error.filePath); | ||
|
|
||
| if (error.kind === 'decorative-icon') { | ||
| console.error( | ||
| `- ${relativeFilePath}:${error.lineNumber} -> decorative icon found: ${error.lineText}` | ||
| ); | ||
| continue; | ||
| } | ||
|
|
||
| const relativeResolvedPath = path.relative(ROOT_DIR, error.resolvedPath); | ||
| console.error( | ||
| `- ${relativeFilePath}:${error.lineNumber} -> ${error.target} (missing: ${relativeResolvedPath})` | ||
| ); | ||
| } | ||
| process.exit(1); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -200,7 +200,9 @@ function buildPrometheusPayload(records, options = {}) { | |
| } | ||
| } | ||
|
|
||
| lines.push( | ||
| `# HELP ${METRIC_PREFIX}_file_count Number of files exercised by the stress scenario.` | ||
| ); | ||
| lines.push(`# TYPE ${METRIC_PREFIX}_file_count gauge`); | ||
|
|
||
| for (const record of records) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,10 +127,12 @@ async function runPerfMetricsJob(options = {}) { | |
| ); | ||
| } | ||
|
|
||
| const jobName = | ||
| (env.PUSHGATEWAY_JOB || DEFAULT_PUSHGATEWAY_JOB).trim() || DEFAULT_PUSHGATEWAY_JOB; | ||
| const instanceName = | ||
| (env.PUSHGATEWAY_INSTANCE || '').trim() || buildDefaultInstanceName(nowFn(), hostName); | ||
| const strictMode = | ||
| (env.PUSHGATEWAY_STRICT || 'true').trim().toLowerCase() === 'false' ? 'false' : 'true'; | ||
| const timeoutMs = toFiniteNumber(env.PROMETHEUS_VERIFY_TIMEOUT_MS) || 60_000; | ||
| const pollIntervalMs = toFiniteNumber(env.PROMETHEUS_VERIFY_POLL_INTERVAL_MS) || 5_000; | ||
| const minPublishTimestampSeconds = Math.floor(nowFn() / 1000); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -203,7 +203,8 @@ function runWithNativeScanner(scannerOptions, token) { | |
| const scannerOptionsForArgs = { ...scannerOptions }; | ||
| delete scannerOptionsForArgs['sonar.token']; | ||
| const args = Object.entries(scannerOptionsForArgs).map(([key, value]) => `-D${key}=${value}`); | ||
| const useWindowsShell = | ||
| process.platform === 'win32' && scannerBinary.toLowerCase().endsWith('.bat'); | ||
| const scannerEnv = { ...process.env }; | ||
| if (token) { | ||
| scannerEnv.SONAR_TOKEN = token; | ||
|
|
@@ -278,7 +279,11 @@ function resolveNativeScannerPath() { | |
| function isNpmScannerWrapperPath(scannerPath) { | ||
| const normalizedPath = path.normalize(scannerPath).toLowerCase(); | ||
| const wrapperSuffix = path | ||
| .join( | ||
| 'node_modules', | ||
| '.bin', | ||
| process.platform === 'win32' ? 'sonar-scanner.cmd' : 'sonar-scanner' | ||
| ) | ||
| .toLowerCase(); | ||
| return normalizedPath.endsWith(wrapperSuffix); | ||
| } | ||
|
|
@@ -397,9 +402,7 @@ try { | |
| console.log( | ||
| '2. Check if the project exists on the server or if you have permission to create it' | ||
| ); | ||
| console.log('3. Verify the token has not expired and is valid for the specified project key'); | ||
| process.exit(1); | ||
| } else { | ||
| console.log('SonarQube scan completed successfully!'); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.