Skip to content

Integrate review feedback for Renovate + CI lockfile installs #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mehdi-Bl merged 1 commit into from
Feb 8, 2026
Merged

Integrate review feedback for Renovate + CI lockfile installs #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,19 +184,19 @@ jobs:
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
with:
name: windows-artifacts
path: artifacts
path: artifacts/windows

- name: Download Linux artifacts
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
with:
name: linux-artifacts
path: artifacts
path: artifacts/linux

- name: Download macOS artifacts
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
with:
name: macos-artifacts
path: artifacts
path: artifacts/macos

- name: Create Release
uses: softprops/action-gh-release@6da8fa9354ddfdc4aeace5fc48d7f679b5214090
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
package-manager-cache: false

@sourcery-ai sourcery-ai Bot Feb 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): You might want to enable the built-in dependency cache now that npm ci is being used.

Given this job now uses npm ci with setup-node configured for package-manager: npm, consider setting package-manager-cache: npm instead of false to speed up repeat SonarCloud runs while retaining deterministic installs.

Suggested change
package-manager-cache: false
package-manager-cache: npm


- name: Install dependencies
run: npm install
run: npm ci

- name: Run tests with coverage
continue-on-error: true
Expand Down
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
/temp

# Package files
package-lock.json
yarn.lock

# Logs
Expand Down
Loading
Loading