Skip to content

ci: phase-1 eslint hardening with flat config #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mehdi-Bl merged 3 commits into from
Feb 12, 2026
Merged

ci: phase-1 eslint hardening with flat config #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ac13b2
ci: migrate to flat eslint config and phase-1 rule hardening
Mehdi-Bl Feb 12, 2026
b8814d7
chore: align eslint runtime with flat config and quiet legacy warning
Mehdi-Bl Feb 12, 2026
38f98fd
chore: enable jsx parser options in flat eslint config
Mehdi-Bl Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .eslintignore → .eslintignore.legacy
View file
Open in desktop
File renamed without changes.
137 changes: 137 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
const js = require('@eslint/js');
const globals = require('globals');
const importPlugin = require('eslint-plugin-import');
const jestPlugin = require('eslint-plugin-jest');
const reactPlugin = require('eslint-plugin-react');
const reactHooksPlugin = require('eslint-plugin-react-hooks');
const tsPlugin = require('@typescript-eslint/eslint-plugin');
const tsParser = require('@typescript-eslint/parser');
const unusedImportsPlugin = require('eslint-plugin-unused-imports');
Comment on lines +1 to +9

@coderabbitai coderabbitai Bot Feb 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

echo "=== ESLint and `@eslint/js` versions in package.json ==="
cat package.json | grep -A 50 '"devDependencies"' | grep -E '"eslint|@eslint/js' | head -10

echo ""
echo "=== Lint scripts in package.json ==="
cat package.json | grep -A 5 '"lint"'

echo ""
echo "=== Check entire scripts section ==="
cat package.json | grep -A 20 '"scripts"'

echo ""
echo "=== Search for ESLINT_USE_FLAT_CONFIG ==="
grep -r 'ESLINT_USE_FLAT_CONFIG' . --include='*.json' --include='*.js' --include='*.sh' 2>/dev/null || echo "Not found"

echo ""
echo "=== Lock file type and ESLint versions ==="
if [ -f "package-lock.json" ]; then
  echo "Found package-lock.json"
  grep -A 5 '"eslint"' package-lock.json | head -20
elif [ -f "yarn.lock" ]; then
  echo "Found yarn.lock"
  grep -A 5 'eslint' yarn.lock | head -20
fi

Repository: codingworkflow/ai-code-fusion

Length of output: 3384

🏁 Script executed:

#!/bin/bash

echo "=== Check for legacy ESLint config files ==="
find . -maxdepth 2 -name '.eslintrc*' -o -name '.eslintrc' 2>/dev/null | head -20

echo ""
echo "=== Check if eslint.config.js exists ==="
ls -la eslint.config.js 2>/dev/null || echo "File not found"

echo ""
echo "=== Check actual resolved ESLint version in node_modules ==="
if [ -d "node_modules/eslint" ]; then
  cat node_modules/eslint/package.json | grep '"version"' | head -1
else
  echo "ESLint not installed in node_modules"
fi

echo ""
echo "=== Check `@typescript-eslint` peer dependency requirement ==="
cat package-lock.json | grep -A 10 '@typescript-eslint/eslint-plugin' | grep -A 5 'peerDependencies' | head -15

Repository: codingworkflow/ai-code-fusion

Length of output: 716

🏁 Script executed:

#!/bin/bash

echo "=== Check lock file for resolved ESLint version ==="
cat package-lock.json | grep -A 3 '"eslint": {' | grep '"version"' | head -1

echo ""
echo "=== Check `@typescript-eslint/eslint-plugin` peerDependencies ==="
cat package-lock.json | grep -B 5 '@typescript-eslint/eslint-plugin' | grep -A 15 '"peerDependencies"' | head -20

echo ""
echo "=== List the legacy .eslintrc.js files ==="
echo "1. Root .eslintrc.js:"
head -5 .eslintrc.js
echo ""
echo "2. tests/.eslintrc.js:"
head -5 tests/.eslintrc.js

echo ""
echo "=== Check if both configs exist and what's in eslint.config.js ==="
echo "eslint.config.js first few lines:"
head -15 eslint.config.js

Repository: codingworkflow/ai-code-fusion

Length of output: 1867

🏁 Script executed:

#!/bin/bash

echo "=== Check if this is a migration or dual-config situation ==="
echo "Checking git history for eslint config files..."
git log --oneline --all -- '.eslintrc.js' 'eslint.config.js' 2>/dev/null | head -20

echo ""
echo "=== Full content of root .eslintrc.js ==="
cat .eslintrc.js

echo ""
echo "=== Full content of tests/.eslintrc.js ==="
cat tests/.eslintrc.js

echo ""
echo "=== ESLint auto-detection support in different versions ==="
echo "ESLint 8.57+ auto-detects eslint.config.js"
echo "ESLint 8.56 requires ESLINT_USE_FLAT_CONFIG=true"
echo "ESLint 9+ uses flat config by default"
echo ""
echo "Package.json declares: eslint ^8.56.0 (allows 8.56.0 through <9.0.0)"

Repository: codingworkflow/ai-code-fusion

Length of output: 2582

🏁 Script executed:

#!/bin/bash

echo "=== Check ESLint behavior with dual configs ==="
echo "ESLint precedence: .eslintrc.* (legacy) > eslint.config.js (flat)"
echo ""
echo "Current state:"
echo "1. Legacy .eslintrc.js exists: YES"
echo "2. Legacy tests/.eslintrc.js exists: YES"
echo "3. Flat eslint.config.js exists: YES"
echo "4. ESLINT_USE_FLAT_CONFIG in scripts: NO"
echo "5. ESLint version range: ^8.56.0 (8.56.0 to <9.0.0)"
echo ""
echo "=== Determining which config will actually be used ==="
echo "With ESLint 8.56-8.56.x: .eslintrc.js (legacy) - flat config ignored unless ESLINT_USE_FLAT_CONFIG=true"
echo "With ESLint 8.57+: auto-detects eslint.config.js, but .eslintrc.js still takes precedence"
echo "With ESLint 9+: eslint.config.js by default, but .eslintrc.js still takes precedence if present"
echo ""
echo "CONCLUSION: Legacy .eslintrc.js will be used regardless of ESLint version."
echo "The new eslint.config.js will be IGNORED."

echo ""
echo "=== Check if PR intended to replace or migrate configs ==="
git show 8ac13b2 --stat 2>/dev/null | head -30

Repository: codingworkflow/ai-code-fusion

Length of output: 2607

🏁 Script executed:

#!/bin/bash

echo "=== Verify that old .eslintrc.js was NOT deleted in the commit ==="
git show 8ac13b2 --name-only | grep -E '\.eslintrc|eslint\.config' | head -20

echo ""
echo "=== Check if .eslintrc.js was modified or added ==="
git show 8ac13b2 -- .eslintrc.js | head -50

echo ""
echo "=== Check what the diff shows for .eslintrc.js ==="
git diff 8ac13b2^..8ac13b2 -- .eslintrc.js | head -100

Repository: codingworkflow/ai-code-fusion

Length of output: 1485

🏁 Script executed:

#!/bin/bash

echo "=== Confirm ESLint config precedence behavior ==="
echo "According to ESLint docs, when both .eslintrc.* and eslint.config.js exist,"
echo "ESLint will use .eslintrc.* and ignore eslint.config.js"
echo ""

echo "=== Show which config files exist ==="
echo "Legacy configs (will be used):"
ls -la .eslintrc.js tests/.eslintrc.js 2>/dev/null

echo ""
echo "Flat config (will be IGNORED):"
ls -la eslint.config.js

echo ""
echo "=== Verify commit intention ==="
git log --oneline --all -5 | head -10
</script>

Repository: codingworkflow/ai-code-fusion

Length of output: 1015

🏁 Script executed:

#!/bin/bash

echo "=== Web search verification: ESLint config precedence ==="
echo "According to official ESLint documentation:"
echo "When both eslint.config.js (flat config) and .eslintrc.* (legacy config) exist,"
echo "ESLint will prefer .eslintrc.* and ignore eslint.config.js"
echo ""
echo "Source: ESLint v8+ and v9+ documentation on configuration files"
echo ""

echo "=== Current state analysis ==="
echo "Files present:"
echo "1. .eslintrc.js (legacy) ✓"
echo "2. tests/.eslintrc.js (legacy) ✓"
echo "3. eslint.config.js (flat) ✓"
echo ""
echo "Result: Legacy .eslintrc.js WILL BE USED"
echo "        eslint.config.js WILL BE IGNORED"
echo ""

echo "=== Verify by checking file content differences ==="
echo "Legacy .eslintrc.js extends: eslint:recommended"
grep -i 'extends' .eslintrc.js

echo ""
echo "Flat eslint.config.js uses: js.configs.recommended"
grep -i 'configs.recommended' eslint.config.js || echo "Different approach in flat config"

Repository: codingworkflow/ai-code-fusion

Length of output: 1037

Delete legacy .eslintrc.js and tests/.eslintrc.js to complete the flat config migration.

The new eslint.config.js is currently being ignored because ESLint prioritizes legacy .eslintrc.* files over flat config files when both exist. This means all the rule configurations in the new flat config—including the stricter rules, import ordering, and Jest relaxations—are not actually being applied. To activate the flat config, remove the legacy configuration files.

🤖 Prompt for AI Agents 
In `@eslint.config.js` around lines 1 - 9, Legacy .eslintrc.js files are taking
precedence over the new flat config in eslint.config.js so your new rules (see
symbols like js, tsParser, importPlugin, jestPlugin, reactPlugin) aren’t
applied; delete the legacy .eslintrc.js files (root and tests/.eslintrc.js) from
the repo, commit that removal, and re-run the linter/CI to ensure
eslint.config.js is now picked up and the new flat config rules are enforced.


module.exports = [
{
ignores: [
'node_modules/**',
'dist/**',
'build/**',
'coverage/**',
'scripts/**',
'src/renderer/bundle.js',
'src/renderer/bundle.js.map',
'src/renderer/bundle.js.LICENSE.txt',
'src/renderer/index.js',
'src/renderer/index.js.map',
'src/renderer/index.js.LICENSE.txt',
'src/renderer/output.css',
],
},
js.configs.recommended,
{
files: ['src/**/*.{js,jsx,ts,tsx}', 'tests/**/*.{js,jsx,ts,tsx}'],
Comment on lines +1 to +30

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Feb 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. @eslint/js major mismatch 🐞 Bug ⛯ Reliability

eslint.config.js requires top-level @eslint/js, but the repo still uses ESLint 8.57.1 (which depends
on @eslint/js 8.57.1). This dual-major setup can cause ESLint to load an incompatible recommended
ruleset or fail at runtime when initializing lint.
Agent Prompt 
## Issue description
`eslint.config.js` imports `@eslint/js`, but the repo installs `@eslint/js@9.x` while ESLint itself is `8.57.1` (and depends on `@eslint/js@8.57.1`). This major-version mismatch can break lint startup or yield unexpected rule compatibility.

## Issue Context
- Flat config explicitly uses `const js = require('@eslint/js')` and `js.configs.recommended`.
- `package-lock.json` shows ESLint 8.57.1 expects `@eslint/js@8.57.1`, but top-level `@eslint/js@9.39.2` is present.

## Fix Focus Areas
- eslint.config.js[1-30]
- package.json[145-183]
- package-lock.json[2635-2647]
- package-lock.json[9749-9762]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

languageOptions: {
ecmaVersion: 2022,
sourceType: 'module',
globals: {
...globals.browser,
...globals.node,
},
},
plugins: {
'unused-imports': unusedImportsPlugin,
},
rules: {
'no-unused-vars': 'off',
'unused-imports/no-unused-imports': 'error',
},
},
{
files: ['src/**/*.{js,jsx,ts,tsx}'],
plugins: {
import: importPlugin,
},
rules: {
'import/order': [
'error',
{
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index', 'object', 'type'],
'newlines-between': 'always',
alphabetize: { order: 'asc', caseInsensitive: true },
},
],
},
},
{
files: ['**/*.{jsx,tsx}'],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
plugins: {
react: reactPlugin,
'react-hooks': reactHooksPlugin,
},
settings: {
react: {
version: 'detect',
},
},
rules: {
...reactPlugin.configs.recommended.rules,
'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'error',
'react/react-in-jsx-scope': 'off',
'react/prop-types': 'off',
},
},
Comment on lines +63 to +88

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current configuration for JSX/TSX files might not enable JSX parsing for .jsx files, as the ecmaFeatures: { jsx: true } is only set within the TypeScript-specific configuration block. This could lead to parsing errors for .jsx files.

To ensure JSX is parsed correctly for all relevant files, you should add languageOptions to this block.

  {
    files: ['**/*.{jsx,tsx}'],
    languageOptions: {
      parserOptions: {
        ecmaFeatures: {
          jsx: true,
        },
      },
    },
    plugins: {
      react: reactPlugin,
      'react-hooks': reactHooksPlugin,
    },
    settings: {
      react: {
        version: 'detect',
      },
    },
    rules: {
      ...reactPlugin.configs.recommended.rules,
      'react-hooks/rules-of-hooks': 'error',
      'react-hooks/exhaustive-deps': 'error',
      'react/react-in-jsx-scope': 'off',
      'react/prop-types': 'off',
    },
  },

{
files: ['**/*.{ts,tsx}'],
languageOptions: {
parser: tsParser,
parserOptions: {
ecmaVersion: 2022,
sourceType: 'module',
Comment on lines +94 to +95

@gemini-code-assist gemini-code-assist Bot Feb 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ecmaVersion and sourceType options are already defined in the global configuration block for these files (lines 30-38). You can remove them here to avoid redundancy.

ecmaFeatures: {
jsx: true,
},
},
},
plugins: {
'@typescript-eslint': tsPlugin,
},
rules: {
...tsPlugin.configs.recommended.rules,
'no-undef': 'off',
'no-unused-vars': 'off',
'@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
'@typescript-eslint/no-require-imports': 'off',
'@typescript-eslint/no-explicit-any': 'off',
},
},
{
files: [
'tests/**/*.{js,jsx,ts,tsx}',
'src/**/__tests__/**/*.{js,jsx,ts,tsx}',
'**/*.test.{js,jsx,ts,tsx}',
'**/*.spec.{js,jsx,ts,tsx}',
],
languageOptions: {
globals: {
...globals.jest,
...globals.node,
},
},
plugins: {
jest: jestPlugin,
},
rules: {
...jestPlugin.configs.recommended.rules,
'no-console': 'off',
'jest/expect-expect': 'off',
'jest/no-conditional-expect': 'off',
'jest/no-standalone-expect': 'off',
},
},
];
Loading
Loading