feat: generic OIDC auth — discover token endpoint, support audience#3
Merged
Conversation
The SDK no longer hardcodes Zitadel's /oauth/v2/token path. It discovers the token_endpoint from the provider's /.well-known/openid-configuration, so it works with any OIDC-compliant IdP (Zitadel, Keycloak, Okta, Auth0, ...). - auth: discover token_endpoint via OIDC discovery; add optional `audience` (sent as the token-request `audience` param) and `scope` so the issued token's `aud` can match the backend's verified OIDC_AUDIENCE. - models: add OpenIDConfiguration; make TokenResponse.id_token optional (not all providers return one for client_credentials). - client: expose `audience` / `scope` passthrough. - tests: cover endpoint discovery + audience sent/omitted; update mocks for the discovery hop. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK no longer hardcodes Zitadel's /oauth/v2/token path. It discovers the token_endpoint from the provider's /.well-known/openid-configuration, so it works with any OIDC-compliant IdP (Zitadel, Keycloak, Okta, Auth0, ...).
audience(sent as the token-requestaudienceparam) andscopeso the issued token'saudcan match the backend's verified OIDC_AUDIENCE.audience/scopepassthrough.