Refactor/sdk no app creation#4
Merged
Merged
Conversation
A machine client is scoped to the apps it is bound to and has no permission to create new ones, so create_app() always failed for a freshly-minted client with no app. Drop it: the app must be created and bound to the client in the Verdikt admin UI beforehand, then the SDK references it by slug. Update README and SDK.md accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the GET /.well-known issuer-discovery hop — Verdikt is always its own
machine-token issuer, so the extra request returned the base_url the client
already had. The SDK now fetches {base_url}/.well-known/openid-configuration
directly. Remove the WellKnown model and update docs/tests.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pre-commit fired on both push and pull_request, running every PR commit twice — limit push to main. Add a tests workflow (uv run pytest) with the same triggers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.