-
Notifications
You must be signed in to change notification settings - Fork 37
feat(agents): add QueryAgentTool (in preview) for the new data modeling query tool type #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5e5578c
test(agents): branch on expected_type in agent tool tests
ks93 2b07993
test(agents): assert loaded_tool type up front in dump and upsert tests
ks93 a506e4c
feat: add QueryAgentTool for the "query" tool type
ks93 838c777
fix: defensive null handling in QueryAgentToolConfiguration._load
ks93 d6c57a9
fix: address PR feedback on query agent tool
ks93 96d70a7
fix(tests): remove redundant round-trip tests for QueryAgentTool
ks93 349550b
fix(tests): remove redundant test_load_with_configuration
ks93 0780663
chore(codegen): refresh sync_api hash after rebase
ks93 375a55f
docs(agents): pin runtime_version in QueryAgentTool example
ks93 fb96946
fix wrong runtime_version in example
haakonvt ce493ab
simplify code example for agents.upsert
haakonvt 11cb8b0
add a todo
haakonvt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current code raises due to "runtime version does not support it". I'm hesitant to merge code examples that don't work yet - I think the API change has to come first.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, fixed in cd05430. Filed APF-385 to drop the pinned runtime version once the Query tool lands in the default (non-preview) runtime