Skip to content

chore(agents): branch on expected_type in agent tool tests #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haakonvt merged 2 commits into from
Apr 18, 2026

test(agents): assert loaded_tool type up front in dump and upsert tests

a4924df
Select commit
Loading
Failed to load commit list.
Merged

chore(agents): branch on expected_type in agent tool tests #2575

test(agents): assert loaded_tool type up front in dump and upsert tests
a4924df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 18, 2026 in 0s

92.74% (-0.03%) compared to 46babc5

View this Pull Request on Codecov

92.74% (-0.03%) compared to 46babc5

Details

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.74%. Comparing base (46babc5) to head (a4924df).

Files with missing lines Patch % Lines
.../test_data_classes/test_agents/test_agent_tools.py 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
- Coverage   92.76%   92.74%   -0.03%     
==========================================
  Files         480      480              
  Lines       48441    48446       +5     
==========================================
- Hits        44936    44930       -6     
- Misses       3505     3516      +11
Files with missing lines Coverage Δ
.../test_data_classes/test_agents/test_agent_tools.py 98.55% <90.90%> (+0.11%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov