Skip to content

chore(hosted_extractors): fix auto test cleanup with force=True #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haakonvt merged 5 commits into from
Apr 21, 2026
Merged

chore(hosted_extractors): fix auto test cleanup with force=True #2584

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4287e8f
test(hosted_extractors): skip flaky jobs tests until 2026-05-04
ks93 Apr 21, 2026
27623bd
test(hosted_extractors): move skip to conftest so it covers all 4 files
ks93 Apr 21, 2026
f34ef43
adjust flow
andersfylling Apr 21, 2026
f6451e2
Revert all changes since branching from master
haakonvt Apr 21, 2026
f651587
use force=True delete to also remove those with jobs
haakonvt Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/tests_integration/test_api/test_hosted_extractors/conftest.py
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@haakonvt haakonvt Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pytest_collection_modifyitems is a bit overkill here I would say:

pytestmark = pytest.mark.skipif(
    date.today() < _SKIP_UNTIL,
    reason=f"Hosted extractor integration tests are flaky; skip until {_SKIP_UNTIL.isoformat()}"
)

Copy link
Copy Markdown
Contributor

@haakonvt haakonvt Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment, based on the Slack feedback, https://cognitedata.slack.com/archives/C065WLH4G5N/p1776687620276759?thread_ts=1776677363.910429&cid=C065WLH4G5N , we should modify our test setup - the error message we suddenly started getting is the "correct" API response.

Copy link
Copy Markdown
Contributor

@haakonvt haakonvt Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it myself 😉

Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def cleanup_stale_test_sources(cognite_client: CogniteClient) -> None:
and now_ms - s.created_time >= 3 * 60 * 60 * 1000 # type: ignore [attr-defined]
]
if stale:
cognite_client.hosted_extractors.sources.delete(stale, ignore_unknown_ids=True)
cognite_client.hosted_extractors.sources.delete(stale, force=True, ignore_unknown_ids=True)


@pytest.fixture
Expand Down
Loading