feat(Data Modeling): support usedFor=record on containers#2621
Open
evertoncolling wants to merge 3 commits into
Open
feat(Data Modeling): support usedFor=record on containers#2621evertoncolling wants to merge 3 commits into
evertoncolling wants to merge 3 commits into
Conversation
Contributor
Author
|
This one would close #2391 (which was based on v7) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2621 +/- ##
==========================================
- Coverage 93.05% 93.01% -0.05%
==========================================
Files 486 486
Lines 49481 49519 +38
==========================================
+ Hits 46047 46058 +11
- Misses 3434 3461 +27
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to filter containers by the 'used_for' attribute in the Data Modeling API. It adds a new 'ContainerUsedFor' type (supporting 'node', 'edge', 'record', and 'all'), updates the 'list' and 'call' methods in both async and sync container APIs to accept this filter, and includes corresponding unit tests. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for creating and querying records containers via the SDK.
ContainerApply.used_forandContainer.used_forto also accept"record", aligning with the v1 API spec (UsedForenum =node | edge | record | all). Exposes a new publicContainerUsedFortype alias.used_forfilter tocontainers.list()andcontainers(...)(iterate), forwarded as theusedForquery parameter onGET /models/containers. Accepts a single value or a sequence.Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.