😅Fix failing smoke test on greenfield#2956
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2956 +/- ##
==========================================
- Coverage 85.73% 85.72% -0.01%
==========================================
Files 461 461
Lines 42293 42293
==========================================
- Hits 36261 36257 -4
- Misses 6032 6036 +4
🚀 New features to boost your workflow:
|
doctrino
changed the title
| @@ -1,6 +1,5 @@ | |||
| instances: | |||
| - createdTime: 1772711569310 | |||
There was a problem hiding this comment.
createdTime now change for each run.
| # Cleanup for next run. | ||
| destination_node_ids = [node_id for node_ids in destination_by_view_id.values() for node_id in node_ids] | ||
| toolkit_client.tool.instances.delete(destination_node_ids) |
There was a problem hiding this comment.
The smoke tests currently failed because, this PR changed the destination data. Since the destination data is not cleaned up, only added to, then, the test started failing.
| _ = client.tool.instances.create(instance_batch) | ||
| _ = client.tool.instances.create(instance_batch, replace=True) | ||
| except ToolkitAPIError as e: | ||
| raise AssertionError( | ||
| f"Failed to create instance batch for view {view_id!s}. Error: {e}. Batch: {[item.as_id() for item in instance_batch]}" | ||
| ) from e | ||
| if edges: | ||
| try: | ||
| _ = client.tool.instances.create(edges) | ||
| _ = client.tool.instances.create(edges, replace=True) |
There was a problem hiding this comment.
This is strictly not necessary, but I added it as it make the set up more robust. Legacy InField is set up exactly the same way each time, it it pre-exist it will be overwritten.
2 participants
Description
Please describe the change you have made.
Bump