Skip to content

fix(cli): make questionary selection visible on macOS (CDF-27852)#2978

Open
ronpal wants to merge 6 commits into
mainfrom
cdf-27852/toolkit-interactive-prompts-macos-highlight
Open

fix(cli): make questionary selection visible on macOS (CDF-27852)#2978
ronpal wants to merge 6 commits into
mainfrom
cdf-27852/toolkit-interactive-prompts-macos-highlight

Conversation

@ronpal
Copy link
Copy Markdown
Contributor

@ronpal ronpal commented May 5, 2026

Description

When using arrow keys in Questionary select / checkbox prompts, the pointer and highlighted row could be hard or impossible to see on some macOS terminals (e.g. truecolor or contrast issues with fg:#… only). This change uses reverse bold together with the existing Fjord accent for those tokens, and calls apply_questionary_toolkit_defaults() on CLI startup so merged Toolkit styles apply to all Questionary prompts (including those that do not pass style=QUESTIONARY_STYLE).

Fixes CDF-27852.

Bump

  • Patch
  • Skip

Changelog

Improved

  • Visibility on arrow-key selection highlights in interactive CLI prompts on macOS Terminal / iTerm2

ronpal and others added 3 commits April 30, 2026 13:57
Replace bare rich.panel.Panel usage with ToolkitPanel from ui.py,
consistent with the build v2 styling improvements. Also consolidates
three separate clean-mode panels into one with dynamic flag text.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use reverse+bold for pointer/highlighted styles and merge toolkit
questionary defaults so all prompts inherit the fix (CDF-27852).
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@ronpal ronpal marked this pull request as ready for review May 5, 2026 09:27
@ronpal ronpal requested review from a team as code owners May 5, 2026 09:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
42654 36509 86% 80% 🟢

New Files

File Coverage Status
cognite_toolkit/_cdf_tk/ui_checkbox_follow_pointer.py 15% 🟢
TOTAL 15% 🟢

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/commands/deploy.py 86% 🟢
cognite_toolkit/_cdf_tk/ui.py 93% 🟢
cognite_toolkit/_cdf_tk/utils/auth.py 70% 🟢
TOTAL 83% 🟢

updated for commit: 5c9d394 by action🐍

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

❌ Patch coverage is 24.68354% with 119 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.59%. Comparing base (8082a14) to head (5c9d394).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nite_toolkit/_cdf_tk/ui_checkbox_follow_pointer.py 15.15% 112 Missing ⚠️
cognite_toolkit/_cdf_tk/ui.py 72.72% 6 Missing ⚠️
cognite_toolkit/_cdf_tk/utils/auth.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
- Coverage   85.81%   85.59%   -0.22%     
==========================================
  Files         461      462       +1     
  Lines       42433    42654     +221     
==========================================
+ Hits        36413    36509      +96     
- Misses       6020     6145     +125     
Files with missing lines Coverage Δ
cognite_toolkit/_cdf_tk/commands/deploy.py 85.54% <100.00%> (+0.40%) ⬆️
cognite_toolkit/_cdf_tk/utils/auth.py 69.93% <50.00%> (+0.10%) ⬆️
cognite_toolkit/_cdf_tk/ui.py 92.77% <72.72%> (-7.23%) ⬇️
...nite_toolkit/_cdf_tk/ui_checkbox_follow_pointer.py 15.15% <15.15%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant