fix(cli): make questionary selection visible on macOS (CDF-27852)#2978
fix(cli): make questionary selection visible on macOS (CDF-27852)#2978ronpal wants to merge 6 commits into
Conversation
Replace bare rich.panel.Panel usage with ToolkitPanel from ui.py, consistent with the build v2 styling improvements. Also consolidates three separate clean-mode panels into one with dynamic flag text. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use reverse+bold for pointer/highlighted styles and merge toolkit questionary defaults so all prompts inherit the fix (CDF-27852).
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
- Coverage 85.81% 85.59% -0.22%
==========================================
Files 461 462 +1
Lines 42433 42654 +221
==========================================
+ Hits 36413 36509 +96
- Misses 6020 6145 +125
🚀 New features to boost your workflow:
|
Description
When using arrow keys in Questionary
select/checkboxprompts, the pointer and highlighted row could be hard or impossible to see on some macOS terminals (e.g. truecolor or contrast issues withfg:#…only). This change usesreverse boldtogether with the existing Fjord accent for those tokens, and callsapply_questionary_toolkit_defaults()on CLI startup so merged Toolkit styles apply to all Questionary prompts (including those that do not passstyle=QUESTIONARY_STYLE).Fixes CDF-27852.
Bump
Changelog
Improved