[CDF-27549] Add AppsAPI client for the App Hosting API#2986
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2986 +/- ##
==========================================
+ Coverage 85.93% 85.95% +0.01%
==========================================
Files 465 466 +1
Lines 42698 42780 +82
==========================================
+ Hits 36692 36770 +78
- Misses 6006 6010 +4
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the AppsAPI to the toolkit client, enabling management of custom apps on the CDF App Hosting API. Feedback focuses on adhering to the repository's docstring style guide regarding Args and Returns sections, improving type safety for dictionary parameters, refining error handling to avoid swallowing 400 status codes, and optimizing sequential retrieval operations for better performance.
|
@Magssch there's a lot of multipart upload goodies in FileMetadataAPI that I think we should leverage here. Amongst other things, we found that the different cloud providers have different quirks. Suggest you look at that implementation instead of creating your own. |
☂️ Code Coverage
Overall Coverage
New Files
Modified Files
|
Description
Implements the
AppsAPIHTTP client for the CDF App Hosting API, covering version upload(multipart), lifecycle transitions, alias management, listing, retrieval, and deletion.
Wires it into
ToolAPIso part3 can use it from the IO layer.Bump