[CDF-27948] Make Infield config migration tolerate invalid root location configs#3002
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Code Review
This pull request introduces error handling for root location configurations during the migration process, including skipping invalid configurations and displaying a summary of results. The reviewer suggests using the Severity enum instead of magic numbers in the summary display to improve maintainability and consistency.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
==========================================
- Coverage 85.91% 85.91% -0.01%
==========================================
Files 465 465
Lines 42669 42695 +26
==========================================
+ Hits 36660 36682 +22
- Misses 6009 6013 +4
🚀 New features to boost your workflow:
|
Description
cdf migrate infield-configsnow skips root location configurations that are missing required fields or whose root asset has not been migrated yet, instead of failing the entire command on the first bad entry. The purpose of this is to enable partial migrations to CDM and to avoid any potential single misconfigured root location to block an entire project migration. Each skipped location now emits a warning, and a summary panel is printed at the end of the run grouping skips by reason, which should somewhat mitigate the now increased risk of users not acknowledging that a location was skipped due to what could be a real data integrity issue that needs to be addressed.Bump
Changelog
Improved
cdf migrate infield-configsnow migrates the root location configurations it can and reports successes and failures as a summary, instead of aborting on the first invalid or non-migrated location.