envconfig: fix bug where slice data is deleted#5
Open
GiedriusS wants to merge 3 commits intocolega:masterfrom
Open
envconfig: fix bug where slice data is deleted#5GiedriusS wants to merge 3 commits intocolega:masterfrom
GiedriusS wants to merge 3 commits intocolega:masterfrom
Conversation
colega
reviewed
Jan 23, 2023
Comment on lines
+46
to
+50
| { | ||
| Input: Input{ | ||
| Type: "haha", | ||
| }, | ||
| }, |
colega
reviewed
Jan 23, 2023
Comment on lines
+187
to
+191
| if l != 0 { | ||
| f.Set(reflect.MakeSlice(f.Type(), l, l)) | ||
| } else { | ||
| l = f.Len() | ||
| } |
Owner
There was a problem hiding this comment.
I think that we should extend the existing slice if l > f.Len(), wdyt? We could append some empty structs to it and process all env vars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If nothing came through environment variables then let's leave the slice alone and recursively descend.