Update canonical links, HTML/ESLint rules, and dependencies#212
Merged
Conversation
Closed
✅ Deploy Preview for dark-mode-theme-switch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Agent-Logs-Url: https://github.com/coliff/dark-mode-switch/sessions/724fd9f7-e883-4532-93b2-2df87b4e195a Co-authored-by: coliff <1212885+coliff@users.noreply.github.com>
Claude
AI
changed the title
There was a problem hiding this comment.
Pull request overview
This PR performs routine maintenance to improve page metadata, tighten linting, and refresh the minification toolchain for the project’s static demo/build outputs.
Changes:
- Added canonical + license link metadata in
index.html, and removed redundantrole="main"from<main>. - Strengthened HTMLHint/ESLint configurations (new HTMLHint rules; stricter ESLint rules + browser/ES6 env).
- Updated
terserand regenerateddark-mode-switch.min.js.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumps terser version used for minification. |
| index.html | Adds canonical/license links and removes redundant ARIA role. |
| dark-mode-switch.min.js | Regenerated minified output with updated terser. |
| .htmlhintrc | Enables additional HTMLHint rules for buttons/frames. |
| .eslintrc.json | Adds env/parser options and enforces stricter JS lint rules. |
| .eslintignore | Expands ignore pattern to cover all *.min.* artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhances HTML metadata, strengthens linting rules, and updates dependencies per maintenance requirements.
HTML Metadata (
index.html)role="main"from<main>element (implicit ARIA semantics)Linting Configuration
.htmlhintrc: Addedbutton-type-requireandframe-title-requirerules.eslintrc.json: Enhanced with stricter rules:no-undefandno-unused-varsas errorseqeqeq) and explicit braces (curly)no-consolewarning.eslintignore: Broadened to ignore all*.min.*files (was*.min.js)Dependencies
5.19.4to5.46.1