Add linting, spellcheck, and editor configs#214
Merged
Conversation
Owner
coliff
commented
Apr 13, 2026
coliff
commented
- Add project tooling and editor configs: new cspell config and GitHub spellcheck workflow, .prettierignore, .nvmrc and VSCode recommendations/settings.
- Tighten linters and CI: expand .eslintrc rules, update super-linter/codeql YAML headers, enable an HTMLHint rule change.
- Update package.json: add htmlhint and cspell scripts, bump prettier, and record Volta node version.
- Apply small code hygiene changes to source and minified JS ("use strict" and clearer if/else), and normalize README badge text.
✅ Deploy Preview for dark-mode-theme-switch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR adds project tooling (spellcheck/linting/editor configs) and tightens existing lint/CI rules, alongside small code hygiene updates to the dark-mode switch script and documentation.
Changes:
- Add cspell configuration plus a GitHub Actions spellcheck workflow and npm scripts for spellcheck/HTML linting.
- Tighten ESLint rules/config and normalize workflow YAML headers; add Prettier ignore for minified assets.
- Apply minor JS hygiene updates (
"use strict", clearer branching) and small README badge text normalization.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Normalizes the GitHub stars badge label text. |
package.json |
Adds htmlhint/cspell scripts, bumps Prettier, and pins Node via Volta. |
dark-mode-switch.js |
Adds global strict mode and replaces ternary with explicit if/else. |
dark-mode-switch.min.js |
Regenerates/minimally updates minified output to match source hygiene changes. |
.vscode/settings.json |
Adds workspace save/format settings (ESLint fix-on-save, etc.). |
.vscode/extensions.json |
Adds VS Code extension recommendations. |
.prettierignore |
Excludes minified files from Prettier formatting. |
.nvmrc |
Pins Node version for nvm users. |
.htmlhintrc |
Tightens HTMLHint by requiring a canonical link. |
.eslintrc.json |
Expands/strengthens ESLint rules and updates parsing options. |
.cspell.json |
Adds repository spellcheck configuration and custom dictionary words. |
.github/workflows/spellcheck.yml |
Adds CI spellcheck workflow using cspell-action. |
.github/workflows/super-linter.yml |
Adds YAML document start marker. |
.github/workflows/codeql-analysis.yml |
Adds YAML document start marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add project tooling and editor configs: new cspell config and GitHub spellcheck workflow, .prettierignore, .nvmrc and VSCode recommendations/settings. Tighten linters and CI: expand .eslintrc rules, update super-linter/codeql YAML headers, enable an HTMLHint rule change. Update package.json: add htmlhint and cspell scripts, bump prettier, and record Volta node version. Apply small code hygiene changes to source and minified JS ("use strict" and clearer if/else), and normalize README badge text.
Update CI, prettierignore, and README wording
Minor repository tweaks: use consistent double quotes in the spellcheck workflow name, disable VALIDATE_NATURAL_LANGUAGE in the super-linter workflow, add .cspell.json to .prettierignore to avoid formatting the spellcheck config, and change README text to refer to the localStorage API.
Update CI, prettierignore, and README wording
Minor repository tweaks: use consistent double quotes in the spellcheck workflow name, disable VALIDATE_NATURAL_LANGUAGE in the super-linter workflow, add .cspell.json to .prettierignore to avoid formatting the spellcheck config, and change README text to refer to the localStorage API.
Add package.json to .prettierignore; tidy extensions
Add package.json to .prettierignore so Prettier ignores it. Also normalize .vscode/extensions.json by compacting the recommendations array to a single line and adjust newline/EOF formatting in .prettierignore.
Add package.json to .prettierignore; tidy extensions
Add package.json to .prettierignore so Prettier ignores it. Also normalize .vscode/extensions.json by compacting the recommendations array to a single line and adjust newline/EOF formatting in .prettierignore.
Remove .eslintignore and update ESLint config
Delete the standalone .eslintignore and consolidate ignores into .eslintrc.json (added "node_modules/" to ignorePatterns). Also adjust parserOptions.ecmaVersion from 2020 to 2015 to target ES2015 syntax; no other rule changes.
coliff
force-pushed
the
dev/coliff/configs-update
branch
from
f63b231 to
e2a4cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.