bmap-rs: Use sync_data instead of sync_all#119
Draft
obbardc wants to merge 1 commit intocollabora:mainfrom
Draft
bmap-rs: Use sync_data instead of sync_all#119obbardc wants to merge 1 commit intocollabora:mainfrom
obbardc wants to merge 1 commit intocollabora:mainfrom
Conversation
sync_all calls fsync which flushes both data and metadata to the device. For large image writes to slow storage (e.g. SD cards or USB drives) this blocks until all pages have been physically written which takes a LONG time. sync_data (fdatasync) flushes only the file data which is sufficient to ensure the written image is safe to use. Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
Contributor
Author
|
@sjoerdsimons small one for you to take a peek at :-) |
Contributor
Author
|
Not sure if sync_data is the right call or not really. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync_all calls fsync which flushes both data and metadata to the device. For large image writes to slow storage (e.g. SD cards or USB drives) this blocks until all pages have been physically written which takes a LONG time. sync_data (fdatasync) flushes only the file data which is sufficient to ensure the written image is safe to use.