New version with cleanup and ordering fix#2
Open
afrepues wants to merge 3 commits intocollective:masterfrom
Open
New version with cleanup and ordering fix#2afrepues wants to merge 3 commits intocollective:masterfrom
afrepues wants to merge 3 commits intocollective:masterfrom
Conversation
These are created automatically by setuptools, so there is no need to keep them under version control. Doing it can actually lead to unnecessary conflicts under some circumstances.
In some situations, the ISolgemaPortletManagerRetriever would not include the portlet being moved, and the operation would fail with an IndexError. This commit adds a check for the portlet hash inclusion in the list returned by the retriever, and uses the plain delta as the position if it isn't included in the list.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assorted changes: