elevated-access - #1600
Conversation
Change log entry
|
Profile summary: Full profile |
|
Hi, I'll make some time to review this on Wednesday. |
niccokunzmann
left a comment
There was a problem hiding this comment.
I added my thoughts and will have a look at the document again.
|
|
||
| Additionally, the icalendar team may contact you to encourage you to apply. | ||
|
|
||
| The icalendar team recognizes that many individuals might not feel qualified to apply. Please rest assured that the worst that can happen is that the team will say "not yet, but here's a path you can follow to become qualified." The icalendar team wants to lift people up. |
There was a problem hiding this comment.
Can we say "we" instead of icalendar team?
There was a problem hiding this comment.
The Microsoft Style Guide recommends avoiding "we" to focus the subject on the reader, not the product. However, that's a different context.
In this context, "We" may have a negative connotation of exclusivity, or "us, not you, the reader". If you're not a member of "we", then that can be a turn off. At other times, it may include the reader, making it unclear who "we" consists of. I could explicitly state "'We' in this document refers to the icalendar team." but I prefer to explicitly state the subject. It also reinforces that we're a team.
|
|
||
| The icalendar team will review your application, and collect relevant information for evaluation. | ||
|
|
||
| If the icalendar team determines that you qualify for elevated access, then you'll receive an invitation through an email notification from GitHub to accept. |
There was a problem hiding this comment.
We have the maintenance page - we do not need to be a faceless team but people can know who is the team - should that be restructured then?
A few friendly faces with roles.
Hi, we are the team behind icalendar.
Join us... Here is how...
Then three tabs
| Review | Triage | Maintain |
|---|---|---|
| What we really need is review work. We get a lot of contributions and this helps scale up. When you review, you show that you know how to be a team player, not just a coder. | Issues need to be checked and PRs merged. Once you showed that you can review, we can trust you with your judgement on issues and PRs. You know how to cooperate. | It is always good for the project to have a few maintainers.... ???? |
There was a problem hiding this comment.
Maintenance is written primarily for people who are interested in maintaining icalendar. This page's purpose is to describe how to join the icalendar team. Let's not mix their purposes.
I could add a section about who are members of the icalendar team, which coincidentally are those people listed on Maintenance.
For the tabs, Review can be done by anyone with a GitHub account via Read access. Maintainers is outside the scope of this PR, and needs a separate discussion about who may become one. I focused on Triage and getting people to join the icalendar team. In another PR, we could amend this page with how to be promoted to Maintainer, once we determine those qualifications.
There was a problem hiding this comment.
I should remark that GitHub has shitty permission management for FOSS organizations. Access may be granted on the entire organization and all its repos, but not a singular repo. Instead we must use direct individual access.
We can also create an organization team, such as icalendar-triage or icalendar-maintainers, and add members to each team, but that won't change their individual access. It's only practical use is to tag a team or request a review from a team, such as @icalendar-maintainers`, which would send a notification to its members.
| The icalendar team reviews pull requests and issues for quality, makes releases to PyPI, and protects and promotes the icalendar community. | ||
| To familiarize yourself with the icalendar community, read :doc:`index`. | ||
|
|
||
| To encourage collaboration and community, the icalendar team is actively seeking contributors who are interested in elevated access to icalendar to help review and triage issues and pull requests. |
There was a problem hiding this comment.
I would say we are seeking people who are interested in doing the work. I do not really want those who seek the access as primary motivation.
Linked issue
n/a
Description
Documented how to join the icalendar team.
Checklist