Skip to content

Allow property overrides and relocation in allOf/then blocks#26

Merged
ericof merged 2 commits into
mainfrom
fix-parser-overrides
May 27, 2026
Merged

Allow property overrides and relocation in allOf/then blocks#26
ericof merged 2 commits into
mainfrom
fix-parser-overrides

Conversation

@erral
Copy link
Copy Markdown
Member

@erral erral commented May 27, 2026

This PR fixes issue #25 where properties defined in the main 'properties' block were ignored if they also appeared in an 'allOf/if/then' block.

Key changes:

  • Properties in 'then' blocks now merge with and override their base definition in 'properties'.
  • Overridden properties are relocated to follow their gating question in the wizard flow.
  • Support for multiple conditional definitions for the same key.
  • Fixed a bug where shared keys in different 'allOf' branches were being skipped.

Verified with:

  • Library unit tests (including new regression tests).
  • Real-world templates from cookieplone-templates.

cc @pbauer for review.

@erral erral requested a review from ericof as a code owner May 27, 2026 09:12
@erral erral requested a review from pbauer May 27, 2026 09:12
@ericof ericof merged commit f784e18 into main May 27, 2026
11 checks passed
@ericof ericof deleted the fix-parser-overrides branch May 27, 2026 13:31
@erral erral restored the fix-parser-overrides branch May 27, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants