Improve code quality: skipWhitespace helper, fix deprecated API, add tests#1
Merged
Merged
Conversation
… tests - Add `skipWhitespace` utility to `src/utils.ts` and replace four duplicated inline whitespace-skipping loops across both source files - Replace deprecated `str.substr()` with `str.slice()` in the Unicode escape-sequence handler (`src/utils.ts`) - Fix typo in comment: "after.s" → "after." - Add missing description to `parsePrimitive` JSDoc - Add a `primitive values` test suite covering integers, floats, negative numbers, booleans, null, and incomplete primitive tokens https://claude.ai/code/session_01BQNPTY3sESCuvaCozHEQf3
bun install added a configVersion field to the lockfile. https://claude.ai/code/session_01BQNPTY3sESCuvaCozHEQf3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipWhitespaceutility tosrc/utils.tsand replace four duplicated inline whitespace-skipping loops across both source filesstr.substr()withstr.slice()in the Unicode escape-sequence handlerparsePrimitiveJSDocprimitive valuestest suite (8 new tests) covering integers, floats, negative numbers, booleans, null, and partial token handlingTest plan
bun test)bunx biome check src tests)https://claude.ai/code/session_01BQNPTY3sESCuvaCozHEQf3