Skip to content

fix G9Bc rule; Consonant + Virama + ZWNJ + Consonant pattern#127

Merged
cometkim merged 2 commits into
mainfrom
fix-zwnj-break
Apr 15, 2026
Merged

fix G9Bc rule; Consonant + Virama + ZWNJ + Consonant pattern#127
cometkim merged 2 commits into
mainfrom
fix-zwnj-break

Conversation

@cometkim
Copy link
Copy Markdown
Owner

Reported from #124

InCB=None handling was missing, in both the Unicode test data and on my end. I manually added some counterexamples to cover those patterns.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: d90bf7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
unicode-segmenter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (57d2f53) to head (d90bf7e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          922       925    +3     
=========================================
+ Hits           922       925    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 15, 2026

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing fix-zwnj-break (d90bf7e) with main (57d2f53)

Open in CodSpeed

@cometkim cometkim merged commit f5d3453 into main Apr 15, 2026
7 checks passed
@cometkim cometkim deleted the fix-zwnj-break branch April 15, 2026 17:31
cometkim added a commit that referenced this pull request Apr 15, 2026
Affected by recent fixes, I missed doc updates.

See #127
See #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant