Skip to content

reset consonant state on boundary emit#128

Merged
cometkim merged 2 commits into
mainfrom
fix-indic-with-space
Apr 15, 2026
Merged

reset consonant state on boundary emit#128
cometkim merged 2 commits into
mainfrom
fix-indic-with-space

Conversation

@cometkim
Copy link
Copy Markdown
Owner

Also reported from #124

I was aware this would definitely be a problem, but I passed it so naively. The state reset cannot be skipped.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: b1c1ae1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
unicode-segmenter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cometkim cometkim changed the title fix consonant cluster breaks with spaces reset consonant state on boundary emit Apr 15, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 15, 2026

Merging this PR will degrade performance by 7.26%

❌ 1 regressed benchmark
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
grapheme - Hindi 70.6 µs 76.1 µs -7.26%

Comparing fix-indic-with-space (b1c1ae1) with main (f5d3453)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f5d3453) to head (b1c1ae1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          925       926    +1     
=========================================
+ Hits           925       926    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cometkim
Copy link
Copy Markdown
Owner Author

Since essential state resets were previously omitted, performance changes are unavoidable.

@cometkim cometkim merged commit 12dc573 into main Apr 15, 2026
6 of 7 checks passed
@cometkim cometkim deleted the fix-indic-with-space branch April 15, 2026 17:45
cometkim added a commit that referenced this pull request Apr 15, 2026
Affected by recent fixes, I missed doc updates.

See #127
See #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant