FN-14233 Fixed a bug in extra commission calculation for loan amount (priceModifier) and in plugin update notification display logic

CHANGELOG

@@ -1,3 +1,6 @@
+4.2.9
+ - FN-14233 Fixed a bug in extra commission calculation for loan amount (priceModifier) and in plugin update notification display logic.
+
 4.2.8
  - FN-14209 Fixed some bugs.
 

CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [4.2.9](https://github.com/comfino/PrestaShop/tree/4.2.9) (2026-03-06)
+
+[Full Changelog](https://github.com/comfino/PrestaShop/compare/4.2.8...4.2.9)
+
+**Merged pull requests:**
+
+- FN-14233 Fixed a bug in extra commission calculation for loan amount (priceModifier) and in plugin update notification display logic. [\#113](https://github.com/comfino/PrestaShop/pull/113) ([akozubskicr](https://github.com/akozubskicr))
+
 ## [4.2.8](https://github.com/comfino/PrestaShop/tree/4.2.8) (2026-03-04)
 
 [Full Changelog](https://github.com/comfino/PrestaShop/compare/4.2.7...4.2.8)

comfino.php

@@ -37,11 +37,11 @@
 }
 
 if (!defined('COMFINO_VERSION')) {
-    define('COMFINO_VERSION', '4.2.8');
+    define('COMFINO_VERSION', '4.2.9');
 }
 
 if (!defined('COMFINO_BUILD_TS')) {
-    define('COMFINO_BUILD_TS', 1772632040);
+    define('COMFINO_BUILD_TS', 1772806598);
 }
 
 if (!defined('WIDGET_INIT_SCRIPT_HASH')) {
@@ -63,7 +63,7 @@ public function __construct()
     {
         $this->name = 'comfino';
         $this->tab = 'payments_gateways';
-        $this->version = '4.2.8';
+        $this->version = '4.2.9';
         $this->author = 'Comfino';
         $this->module_key = '3d3e14c65281e816da083e34491d5a7f';
 
@@ -426,8 +426,15 @@ private function checkGithubVersion()
         $lastCheckTime = Configuration::get('COMFINO_GITHUB_VERSION_CHECK_TIME');
 
         if ($lastCheckTime && (time() - (int) $lastCheckTime) < 86400) {
-            // Checked within last 24 hours, skip.
-            return;
+            // Checked within last 24 hours - but bypass if the running version changed (e.g. after an update).
+            if (is_array($cachedInfo = json_decode(Configuration::get('COMFINO_GITHUB_VERSION_INFO'), true))
+                && (isset($cachedInfo['current_version']) ? $cachedInfo['current_version'] : '') === COMFINO_VERSION
+            ) {
+                return;
+            }
+
+            // Version changed since last cache - force refresh.
+            Comfino\Update\UpdateManager::forceCheckForUpdates();
         }
 
         $updateInfo = Comfino\Update\UpdateManager::checkForUpdates();

controllers/front/payment.php

@@ -126,10 +126,15 @@ public function postProcess(): void
         }
 
         $initLoanAmount = (int) filter_var($cookie->loan_amount, FILTER_VALIDATE_INT);
-        $priceModifier = (int) filter_var($cookie->price_modifier, FILTER_VALIDATE_INT);
         $loanType = trim(filter_var($cookie->loan_type, FILTER_SANITIZE_STRING));
         $loanTerm = (int) filter_var($cookie->loan_term, FILTER_VALIDATE_INT);
 
+        $priceModifier = filter_var($cookie->price_modifier, FILTER_VALIDATE_INT);
+
+        if ($priceModifier === false || $priceModifier < 0 || $priceModifier > 1000000) {
+            $priceModifier = 0;
+        }
+
         $psOrder = new \Order($this->module->currentOrder);
 
         try {

controllers/front/paywall.php

@@ -43,6 +43,9 @@
 
 class ComfinoPaywallModuleFrontController extends ModuleFrontController
 {
+    /**
+     * @throws Exception
+     */
     public function initContent(): void
     {
         ErrorLogger::init();
@@ -55,13 +58,17 @@ public function initContent(): void
             return;
         }
 
-        if (!Tools::isEmpty('priceModifier') && is_numeric(Tools::getValue('priceModifier'))) {
-            $priceModifier = (int) filter_var(Tools::getValue('priceModifier'), FILTER_VALIDATE_INT);
+        if (!Tools::isEmpty('priceModifier') && ctype_digit(Tools::getValue('priceModifier'))) {
+            $priceModifier = filter_var(Tools::getValue('priceModifier'), FILTER_VALIDATE_INT);
+
+            if ($priceModifier === false || $priceModifier < 0 || $priceModifier > 1000000) {
+                $priceModifier = 0;
+            }
         } else {
             $priceModifier = 0;
         }
 
-        $loanAmount = (int) round(round($this->context->cart->getOrderTotal(), 2) * 100);
+        $cartTotal = (int) round(round($this->context->cart->getOrderTotal(), 2) * 100);
 
         $shopCart = OrderManager::getShopCart($this->context->cart, $priceModifier);
         $allowedProductTypes = SettingsManager::getAllowedProductTypes(
@@ -80,7 +87,7 @@ public function initContent(): void
             '[PAYWALL]',
             'renderPaywall',
             [
-                '$loanAmount' => $loanAmount,
+                '$cartTotal' => $cartTotal,
                 '$priceModifier' => $priceModifier,
                 '$cartTotalValue' => $shopCart->getTotalValue(),
                 '$allowedProductTypes' => $allowedProductTypes,
@@ -99,7 +106,7 @@ public function initContent(): void
 
         try {
             $paywallContents = ApiClient::getInstance()->getPaywall(
-                new LoanQueryCriteria($loanAmount, null, null, $allowedProductTypes),
+                new LoanQueryCriteria($cartTotal, null, null, $priceModifier, $allowedProductTypes),
                 $paywallUrl
             );
 

src/View/FrontendManager.php

@@ -245,13 +245,13 @@ public static function displayGithubVersionNotice(\Comfino $module): string
         }
 
         $updateInfo = json_decode($updateInfoJson, true);
+        $githubVersion = $updateInfo['github_version'] ?? '';
 
-        if (!isset($updateInfo['update_available']) || !$updateInfo['update_available']) {
+        // Re-evaluate against current version to avoid showing stale cached notice after an update.
+        if (empty($githubVersion) || !version_compare($githubVersion, COMFINO_VERSION, '>')) {
             return '';
         }
 
-        $githubVersion = $updateInfo['github_version'] ?? '';
-
         // Check if this version was already dismissed.
         if ($dismissedVersion === $githubVersion) {
             return '';