feat: updates for Quote Slice#846
Merged
acatcalledfrank merged 17 commits intomasterfrom Mar 12, 2026
Merged
Conversation
- fixing shadows - moving height limits onto inner wrapper - upping desktop font size and lowering character floor
…brary into ENG-4290_quote-slice_v2
AndyEPhipps
reviewed
Mar 12, 2026
| const maxCharacterCount = 500; | ||
| // - shorter quotes, up to XX characters, will be full size | ||
| // - longer quotes, over YY characters, will be at the smallest size | ||
| // - mid-length quotes, between XX and YY characters, will scale down proportionally |
Contributor
There was a problem hiding this comment.
Where do these values actually get determined; can we signpost a bit?
Contributor
Author
There was a problem hiding this comment.
done — they're referring to the consts right below (but not in a very clear way, obviously 🙂)
|
🎉 This PR is included in version 8.66.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
Minor tweaks and updates to the Quote Slice
Why is this required?
Fixing a few minor issues
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...