Skip to content

feat: adding design amends/updates to Stats Slice#853

Merged
acatcalledfrank merged 3 commits intomasterfrom
ENG-4289_stats-slice_v2
Mar 11, 2026
Merged

feat: adding design amends/updates to Stats Slice#853
acatcalledfrank merged 3 commits intomasterfrom
ENG-4289_stats-slice_v2

Conversation

@acatcalledfrank
Copy link
Contributor

PR Titles

feat: adding design amends/updates to Stats Slice

PR description

What is it doing?

Implementing minor feedback from design/UX; updating padding and fonts

Quick Checklist:

  • My PR title follows the Conventional Commit spec.
  • I have filled out the PR description as per the template above.

Important! - lastly, make sure to squash merge...

@acatcalledfrank acatcalledfrank self-assigned this Mar 11, 2026
@media ${({ theme }) => theme.breakpoints2026('L')} {
font-size: ${({ theme }) => theme.fontSize('xxl')};
}
${({ theme }) => css`${fontHelper(theme, 'h1')}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like an h1, but is an h2 really, in order to make it more semantically correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly that.

@acatcalledfrank acatcalledfrank merged commit 988ae90 into master Mar 11, 2026
9 checks passed
@acatcalledfrank acatcalledfrank deleted the ENG-4289_stats-slice_v2 branch March 11, 2026 11:58
@github-actions
Copy link

🎉 This PR is included in version 8.64.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants