Skip to content

fix: resolving issue with gallery in combination with new nav#855

Merged
acatcalledfrank merged 2 commits intomasterfrom
4535-dynamic-gallery-component_updates_v4
Mar 16, 2026
Merged

fix: resolving issue with gallery in combination with new nav#855
acatcalledfrank merged 2 commits intomasterfrom
4535-dynamic-gallery-component_updates_v4

Conversation

@acatcalledfrank
Copy link
Contributor

PR description

What is it doing?

The gallery lightbox sets various "scroll fix" properties on the document element to prevent scrolling — unfortunately these conflict with the new nav's mobile view when the page is scrolled, and break the menu badly enough to require a page reload.

This PR:

  • moves the lightbox scroll-fix styles onto the body element
  • removes the overflow style when no longer needed, rather than "resetting" it to auto

Quick Checklist:

  • My PR title follows the Conventional Commit spec.
  • I have filled out the PR description as per the template above.

Important! - lastly, make sure to squash merge...

We now use `removeProperty` to remove them rather than resetting to eg `auto` because that was breaking the nav
@acatcalledfrank acatcalledfrank self-assigned this Mar 16, 2026
@AndyEPhipps
Copy link
Contributor

If you could please put together a CRcom PR pulling this version in, and get it assigned to Krupa to review with some context, that'd be great!

image

@acatcalledfrank acatcalledfrank merged commit 8647b22 into master Mar 16, 2026
9 checks passed
@acatcalledfrank acatcalledfrank deleted the 4535-dynamic-gallery-component_updates_v4 branch March 16, 2026 16:22
@github-actions
Copy link

🎉 This PR is included in version 8.66.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants