fix: ENG-3901 Adds additional postcode validation#437
Draft
curlyfriesplease wants to merge 6 commits intomasterfrom
Draft
fix: ENG-3901 Adds additional postcode validation#437curlyfriesplease wants to merge 6 commits intomasterfrom
curlyfriesplease wants to merge 6 commits intomasterfrom
Conversation
curlyfriesplease
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENG-3901
On Friday we found there's an inconsistency between the regex used by our storybook's PostcodeLookup component, and the backend of serverless-giftaid.
We found that the backend was stricter than storybook in its validation of the outcode (the first half of a postcode) - the postcode
cro 7tpwas being allowed by the frontend, but rejected by the backend.The goal here is to override the regex validation used here in the frontend, so that the FE & BE are sticking to the same rule.
To test it works, we should NOT be able to use the above postcode in either form (the main page, or the /update page)