Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements FLASH as SPA with SolidJS #42
Summary:
This PR introduces a basic migration from React to SolidJS, aiming to explore potential performance improvements. This is an early implementation and not yet production-ready. If there's sufficient interest, I will continue to fully migrate the app to a proper SolidJS ecosystem, including linting, testing, and other essential tools.
Notes:
Architectural Decision: SPA vs SSR vs SSG
I opted for a **Single Page Application ** architecture in SolidJS, and here's the rationale behind this decision:
Performance:
Since Flash is not content-heavy, an SPA provides better performance after the initial load.
SEO Not a Priority:
Given that SEO isn't a major concern for this project, we don't require the potential SEO benefits of SSR.
Dynamic Content:
Flash seems largely dynamic and user-specific, such as device connection statuses and flashing progress, which aligns well with the SPA model.
Offline Capabilities (Future Consideration as there seems to be an ongoing Bounty as well):
Should we need PWA features in the future, the SPA architecture simplifies the process.
Benchmarks:
ReactJS Performance:
SolidJS Performance:
Let me know if you'd like any further tweaks!