Skip to content

teleop in connect#37796

Closed
stefpi wants to merge 28 commits into
masterfrom
connect-teleop
Closed

teleop in connect#37796
stefpi wants to merge 28 commits into
masterfrom
connect-teleop

Conversation

@stefpi
Copy link
Copy Markdown
Contributor

@stefpi stefpi commented Apr 10, 2026

body joystick teleop support for connect

  • getNotCar and startJoystickStream in athenad
  • move to 1 video channel (swap which camera's frames going into stream encoder)
  • play sound bites and swap cameras through data channel
  • append timing information in frame headers for debug stats on frontend

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

UI Preview

mici: ⚠️ Videos differ! View Diff Report
big: ⚠️ Videos differ! View Diff Report

Comment thread cereal/log.capnp
Comment on lines 2486 to 2488
livestreamRoadEncodeData @120 :EncodeData;
livestreamWideRoadEncodeData @121 :EncodeData;
livestreamDriverEncodeData @122 :EncodeData;
Copy link
Copy Markdown
Contributor Author

@stefpi stefpi Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these are no longer used should they be removed or deprecated?

@stefpi stefpi marked this pull request as ready for review April 13, 2026 23:08
@stefpi stefpi requested review from adeebshihadeh and removed request for adeebshihadeh April 14, 2026 18:10
@stefpi stefpi marked this pull request as draft April 14, 2026 19:20
@stefpi stefpi marked this pull request as ready for review April 14, 2026 21:51
@stefpi stefpi requested a review from adeebshihadeh April 14, 2026 22:13
@stefpi stefpi mentioned this pull request May 11, 2026
@stefpi stefpi removed the request for review from adeebshihadeh May 11, 2026 18:40
@stefpi
Copy link
Copy Markdown
Contributor Author

stefpi commented May 12, 2026

This PR is now further split into

athena + webrtc #38011 (main)
sound requests #38012
1 encoder #38013
frame timing #38014

@stefpi stefpi closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant