vendor acados via commaai/dependencies#37932
Open
adeebshihadeh wants to merge 3 commits intocommaai:masterfrom
Open
vendor acados via commaai/dependencies#37932adeebshihadeh wants to merge 3 commits intocommaai:masterfrom
adeebshihadeh wants to merge 3 commits intocommaai:masterfrom
Conversation
Replaces the in-repo third_party/acados/ build with the new
release-acados shim from commaai/dependencies. The shim ships
acados v0.2.2 (libs + headers + acados_template + t_renderer) plus a
slimmed casadi 3.6.7 (~28 MB vs the ~214 MB upstream wheel) so we no
longer need a direct casadi dependency either.
- import acados as acados_pkg in SConstruct + lat/long MPC SConscripts;
use acados_pkg.{INCLUDE_DIR, LIB_DIR, TEMPLATE_DIR, TERA_PATH} instead
of #third_party/acados paths.
- lat_mpc.py / long_mpc.py: from acados.acados_template import ...
(was openpilot.third_party.acados.acados_template).
- pyproject: + acados shim, - casadi (now bundled with acados).
- third_party/acados/ is fully removed from the tree.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.