speedup pytest collection#37977
Open
hypery11 wants to merge 1 commit intocommaai:masterfrom
Open
Conversation
Contributor
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
Contributor
UI Previewmici: |
hypery11
force-pushed
the
pytest-collection
branch
from
842f407 to
613379d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a few sources of unnecessary work during
pytest --collect-only:conftest.py'scollect_ignore_glob(selfdrive/debug,selfdrive/modeld) andcollect_ignore(process_replay tests) into directory/file--ignoreentries onaddopts.--ignoreskips walking the tree entirely;collect_ignore_globstill visits every.pyto filter it out.test_widget_leaks.pyinto the test body. The test is@pytest.mark.skipfor segfaults so the imports were paying ~136ms (raylib + UI stack) on every collection for nothing.-n auto --dist=loadgroupdeliberately left in addopts so test runs stay parallel.Local macOS timings are not representative (master segfaults during collection here, our env is missing some Linux deps). Happy to add CI timings if there's a reasonable way to extract them.
Fixes #32611